| Message ID | 1411419245-25799-1-git-send-email-greearb@candelatech.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
greearb@candelatech.com writes: > From: Ben Greear <greearb@candelatech.com> > > There are not many of these messages producted by the > firmware, but they are generally fairly useful, so print > them at info level. > > Signed-off-by: Ben Greear <greearb@candelatech.com> > --- > drivers/net/wireless/ath/ath10k/wmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c > index cd60940..6be62ac 100644 > --- a/drivers/net/wireless/ath/ath10k/wmi.c > +++ b/drivers/net/wireless/ath/ath10k/wmi.c > @@ -2050,7 +2050,7 @@ static void ath10k_wmi_event_debug_print(struct ath10k *ar, > /* the last byte is always reserved for the null character */ > buf[i] = '\0'; > > - ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi event debug print '%s'\n", buf); > + ath10k_info(ar, "wmi event debug print '%s'\n", buf); This does not bring any extra value to normal users, it's only useful to firmware engineers. That's why it needs to stay as a debug message. Maybe we should add a new debug level just for these events, would that help?
On 09/23/2014 06:13 AM, Kalle Valo wrote: > greearb@candelatech.com writes: > >> From: Ben Greear <greearb@candelatech.com> >> >> There are not many of these messages producted by the >> firmware, but they are generally fairly useful, so print >> them at info level. >> >> Signed-off-by: Ben Greear <greearb@candelatech.com> >> --- >> drivers/net/wireless/ath/ath10k/wmi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c >> index cd60940..6be62ac 100644 >> --- a/drivers/net/wireless/ath/ath10k/wmi.c >> +++ b/drivers/net/wireless/ath/ath10k/wmi.c >> @@ -2050,7 +2050,7 @@ static void ath10k_wmi_event_debug_print(struct ath10k *ar, >> /* the last byte is always reserved for the null character */ >> buf[i] = '\0'; >> >> - ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi event debug print '%s'\n", buf); >> + ath10k_info(ar, "wmi event debug print '%s'\n", buf); > > This does not bring any extra value to normal users, it's only useful to > firmware engineers. That's why it needs to stay as a debug message. > Maybe we should add a new debug level just for these events, would that > help? It will help users trying to tune the maximum resource combinations (vdevs + peers + tx-descriptors + skid-len, etc) because my firmware prints out remaining RAM/IRAM after booting up. But, a separate debug flag would be fine. Thanks, Ben
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index cd60940..6be62ac 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -2050,7 +2050,7 @@ static void ath10k_wmi_event_debug_print(struct ath10k *ar, /* the last byte is always reserved for the null character */ buf[i] = '\0'; - ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi event debug print '%s'\n", buf); + ath10k_info(ar, "wmi event debug print '%s'\n", buf); } static void ath10k_wmi_event_pdev_qvit(struct ath10k *ar, struct sk_buff *skb)