diff mbox

mac80211: minstrel_ht: fix MCS_GROUP_RATES usage

Message ID 1411950990-24365-1-git-send-email-karl.beldan@gmail.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Karl Beldan Sept. 29, 2014, 12:36 a.m. UTC 
From: Karl Beldan <karl.beldan@rivierawaves.com>

Commit 4441e8e9 ("mac80211: improve minstrel_ht rate sorting by
throughput & probability") replaced the constant 8 with MCS_GROUP_RATES
when getting the number of streams of an HT MCS. See commit 7a5e3fa2
("mac80211: minstrel_ht: replace some occurences of MCS_GROUP_RATES").

Signed-off-by: Karl Beldan <karl.beldan@rivierawaves.com>
---
 net/mac80211/rc80211_minstrel_ht.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Johannes Berg Oct. 9, 2014, 8:58 a.m. UTC | #1 
On Mon, 2014-09-29 at 02:36 +0200, Karl Beldan wrote:
> From: Karl Beldan <karl.beldan@rivierawaves.com>
> 
> Commit 4441e8e9 ("mac80211: improve minstrel_ht rate sorting by
> throughput & probability") 

That commit ID doesn't exist? Anyway, I fixed it.

I applied the patch - but to mac80211-next since presumably you want to
build on this and it doesn't matter much on mac80211.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Karl Beldan Oct. 9, 2014, 12:59 p.m. UTC | #2 
On Thu, Oct 09, 2014 at 10:58:21AM +0200, Johannes Berg wrote:
> On Mon, 2014-09-29 at 02:36 +0200, Karl Beldan wrote:
> > From: Karl Beldan <karl.beldan@rivierawaves.com>
> > 
> > Commit 4441e8e9 ("mac80211: improve minstrel_ht rate sorting by
> > throughput & probability") 
> 
> That commit ID doesn't exist? Anyway, I fixed it.
> 
> I applied the patch - but to mac80211-next since presumably you want to
> build on this and it doesn't matter much on mac80211.
> 
Thanks, this was a locally git-applied commit ID.
 
Karl
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/mac80211/rc80211_minstrel_ht.c b/net/mac80211/rc80211_minstrel_ht.c
index df90ce2..17ef54a 100644
--- a/net/mac80211/rc80211_minstrel_ht.c
+++ b/net/mac80211/rc80211_minstrel_ht.c
@@ -135,7 +135,7 @@  minstrel_ht_update_rates(struct minstrel_priv *mp, struct minstrel_ht_sta *mi);
 static int
 minstrel_ht_get_group_idx(struct ieee80211_tx_rate *rate)
 {
-	return GROUP_IDX((rate->idx / MCS_GROUP_RATES) + 1,
+	return GROUP_IDX((rate->idx / 8) + 1,
 			 !!(rate->flags & IEEE80211_TX_RC_SHORT_GI),
 			 !!(rate->flags & IEEE80211_TX_RC_40_MHZ_WIDTH));
 }