| Message ID | 000101cfee66$7d1ed040$775c70c0$%han@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On 10/22/2014 10:10 PM, Jingoo Han wrote: > Make local symbol static, because this is used only in this file. > > Signed-off-by: Jingoo Han<jg1.han@samsung.com> > --- > drivers/pci/host/pci-keystone-dw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pci-keystone-dw.c b/drivers/pci/host/pci-keystone-dw.c > index 34086ce..4a97cd1 100644 > --- a/drivers/pci/host/pci-keystone-dw.c > +++ b/drivers/pci/host/pci-keystone-dw.c > @@ -201,7 +201,7 @@ static int ks_dw_pcie_msi_map(struct irq_domain *domain, unsigned int irq, > return 0; > } > > -const struct irq_domain_ops ks_dw_pcie_msi_domain_ops = { > +static const struct irq_domain_ops ks_dw_pcie_msi_domain_ops = { > .map = ks_dw_pcie_msi_map, > }; > Jingoo Han, Thanks for the patch. Acked-by: Murali Karicheri <m-karicheri2@ti.com>
On 10/22/2014 07:10 PM, Jingoo Han wrote: > Make local symbol static, because this is used only in this file. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > drivers/pci/host/pci-keystone-dw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pci-keystone-dw.c b/drivers/pci/host/pci-keystone-dw.c > index 34086ce..4a97cd1 100644 > --- a/drivers/pci/host/pci-keystone-dw.c > +++ b/drivers/pci/host/pci-keystone-dw.c > @@ -201,7 +201,7 @@ static int ks_dw_pcie_msi_map(struct irq_domain *domain, unsigned int irq, > return 0; > } > > -const struct irq_domain_ops ks_dw_pcie_msi_domain_ops = { > +static const struct irq_domain_ops ks_dw_pcie_msi_domain_ops = { > .map = ks_dw_pcie_msi_map, > }; > > Looks correct. FWIW, Acked-by: Santosh Shilimkar<ssantosh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Oct 23, 2014 at 11:10:16AM +0900, Jingoo Han wrote: > Make local symbol static, because this is used only in this file. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> Applied to pci/host-keystone for v3.19 with acks from Murali and Santosh, thanks! > --- > drivers/pci/host/pci-keystone-dw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pci-keystone-dw.c b/drivers/pci/host/pci-keystone-dw.c > index 34086ce..4a97cd1 100644 > --- a/drivers/pci/host/pci-keystone-dw.c > +++ b/drivers/pci/host/pci-keystone-dw.c > @@ -201,7 +201,7 @@ static int ks_dw_pcie_msi_map(struct irq_domain *domain, unsigned int irq, > return 0; > } > > -const struct irq_domain_ops ks_dw_pcie_msi_domain_ops = { > +static const struct irq_domain_ops ks_dw_pcie_msi_domain_ops = { > .map = ks_dw_pcie_msi_map, > }; > > -- > 1.7.9.5 > > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/host/pci-keystone-dw.c b/drivers/pci/host/pci-keystone-dw.c index 34086ce..4a97cd1 100644 --- a/drivers/pci/host/pci-keystone-dw.c +++ b/drivers/pci/host/pci-keystone-dw.c @@ -201,7 +201,7 @@ static int ks_dw_pcie_msi_map(struct irq_domain *domain, unsigned int irq, return 0; } -const struct irq_domain_ops ks_dw_pcie_msi_domain_ops = { +static const struct irq_domain_ops ks_dw_pcie_msi_domain_ops = { .map = ks_dw_pcie_msi_map, };
Make local symbol static, because this is used only in this file. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/pci/host/pci-keystone-dw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)