| Message ID | 1417588565-26215-6-git-send-email-wens@csie.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Wed, Dec 03, 2014 at 02:36:00PM +0800, Chen-Yu Tsai wrote: > Add the device tree nodes for the mmc config clock nodes. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > arch/arm/boot/dts/sun9i-a80.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi > index f3cac3a..f425d9d 100644 > --- a/arch/arm/boot/dts/sun9i-a80.dtsi > +++ b/arch/arm/boot/dts/sun9i-a80.dtsi > @@ -325,6 +325,19 @@ > */ > ranges = <0 0 0 0x20000000>; > > + mmc_config_clk: clk@01c23000 { > + compatible = "allwinner,sun9i-a80-mmc-clk"; > + reg = <0x01c13000 0x10>; The reg and the unit-address don't match. Also, this used to be defined in the clocks node for the USB case, it would be good to do the same here. Maxime
On Sun, Dec 7, 2014 at 11:00 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Wed, Dec 03, 2014 at 02:36:00PM +0800, Chen-Yu Tsai wrote: >> Add the device tree nodes for the mmc config clock nodes. >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> >> --- >> arch/arm/boot/dts/sun9i-a80.dtsi | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi >> index f3cac3a..f425d9d 100644 >> --- a/arch/arm/boot/dts/sun9i-a80.dtsi >> +++ b/arch/arm/boot/dts/sun9i-a80.dtsi >> @@ -325,6 +325,19 @@ >> */ >> ranges = <0 0 0 0x20000000>; >> >> + mmc_config_clk: clk@01c23000 { >> + compatible = "allwinner,sun9i-a80-mmc-clk"; >> + reg = <0x01c13000 0x10>; > > The reg and the unit-address don't match. Will fix. > Also, this used to be defined in the clocks node for the USB case, it > would be good to do the same here. As it is a platform driver, it can't be under the clocks node, which doesn't instantiate platform devices. (That is, assuming you're ok with it being a platform driver.) ChenYu
On Mon, Dec 08, 2014 at 12:00:21AM +0800, Chen-Yu Tsai wrote: > As it is a platform driver, it can't be under the clocks node, which > doesn't instantiate platform devices. (That is, assuming you're ok > with it being a platform driver.) That shouldn't have any impact on the DT itself, but yeah, you're right. I guess we should just kill that clocks node for memory mapped clocks one day. Maxime
diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi index f3cac3a..f425d9d 100644 --- a/arch/arm/boot/dts/sun9i-a80.dtsi +++ b/arch/arm/boot/dts/sun9i-a80.dtsi @@ -325,6 +325,19 @@ */ ranges = <0 0 0 0x20000000>; + mmc_config_clk: clk@01c23000 { + compatible = "allwinner,sun9i-a80-mmc-clk"; + reg = <0x01c13000 0x10>; + clocks = <&ahb0_gates 8>; + clock-names = "ahb"; + resets = <&ahb0_resets 8>; + reset-names = "ahb"; + #clock-cells = <1>; + #reset-cells = <1>; + clock-output-names = "mmc0_config", "mmc1_config", + "mmc2_config", "mmc3_config"; + }; + gic: interrupt-controller@01c41000 { compatible = "arm,cortex-a7-gic", "arm,cortex-a15-gic"; reg = <0x01c41000 0x1000>,
Add the device tree nodes for the mmc config clock nodes. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- arch/arm/boot/dts/sun9i-a80.dtsi | 13 +++++++++++++ 1 file changed, 13 insertions(+)