| Message ID | 1418404441-5518-6-git-send-email-svarbanov@mm-sol.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Friday 12 December 2014 19:14:01 Stanimir Varbanov wrote: > +config ARCH_APQ8084 > + bool "Enable support for APQ8084" > + select HAVE_ARM_ARCH_TIMER > + select PCI > + select PCI_DOMAINS > + select PCI_MSI > + I would prefer not to see 'select PCI' here. Also the driver is written to work without PCI_MSI, so I'd be much happier with just config ARCH_APQ8084 bool "Enable support for APQ8084" select HAVE_ARM_ARCH_TIMER select PCI_DOMAINS if PCI but you could even drop the last line if it's possible that some machines enable only one host bridge. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Arnd, Thanks for the comments! On 12/12/2014 07:33 PM, Arnd Bergmann wrote: > On Friday 12 December 2014 19:14:01 Stanimir Varbanov wrote: >> +config ARCH_APQ8084 >> + bool "Enable support for APQ8084" >> + select HAVE_ARM_ARCH_TIMER >> + select PCI >> + select PCI_DOMAINS >> + select PCI_MSI >> + > > I would prefer not to see 'select PCI' here. Also the driver is written > to work without PCI_MSI, so I'd be much happier with just > > config ARCH_APQ8084 > bool "Enable support for APQ8084" > select HAVE_ARM_ARCH_TIMER > select PCI_DOMAINS if PCI What about this config ARCH_APQ8084 bool "Enable support for APQ8084" select HAVE_ARM_ARCH_TIMER select MIGHT_HAVE_PCI select PCI_DOMAINS if PCI
diff --git a/arch/arm/mach-qcom/Kconfig b/arch/arm/mach-qcom/Kconfig index ee5697b..b8abe7d 100644 --- a/arch/arm/mach-qcom/Kconfig +++ b/arch/arm/mach-qcom/Kconfig @@ -23,6 +23,13 @@ config ARCH_MSM8974 bool "Enable support for MSM8974" select HAVE_ARM_ARCH_TIMER +config ARCH_APQ8084 + bool "Enable support for APQ8084" + select HAVE_ARM_ARCH_TIMER + select PCI + select PCI_DOMAINS + select PCI_MSI + config QCOM_SCM bool
This adds Snapdragon 805 ARM-based SoC as multiplatform compatible platform. Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com> --- arch/arm/mach-qcom/Kconfig | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)