diff mbox

[IWLMVM] Firmware restart issue with 3.19-rc6-wl with AC 3160, REV=0x164

Message ID 1422650111.1919.45.camel@sipsolutions.net (mailing list archive)
State Not Applicable
Delegated to: Johannes Berg
Headers show

Commit Message

Johannes Berg Jan. 30, 2015, 8:35 p.m. UTC 
On Fri, 2015-01-30 at 21:23 +0100, Christian Lamparter wrote:

> [    6.274625] iwlwifi 0000:01:00.0: 0x00000038 | BAD_COMMAND

> [    6.275034] iwlwifi 0000:01:00.0: FW error in SYNC CMD SCD_QUEUE_CFG

WTF. How did the firmware even announce support for this command??

Perhaps I missed it in the log, but which firmware are you using? Any
chance you also upgraded that? Because I can't imagine this code is new
in the tree...

Anyway, make this change:


I guess Emmanuel will look at it on Sunday :)

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Christian Lamparter Jan. 31, 2015, 2:16 p.m. UTC | #1 
Hello,

On Fri, Jan 30, 2015 at 9:35 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Fri, 2015-01-30 at 21:23 +0100, Christian Lamparter wrote:
>> [    6.274625] iwlwifi 0000:01:00.0: 0x00000038 | BAD_COMMAND
>> [    6.275034] iwlwifi 0000:01:00.0: FW error in SYNC CMD SCD_QUEUE_CFG
>
> WTF. How did the firmware even announce support for this command??
>
> Perhaps I missed it in the log, but which firmware are you using? Any
> chance you also upgraded that? Because I can't imagine this code is new
> in the tree...
Uhh, good question: I "think" got this firmware from one of Emmanuel's firmware
announcements. (ls says "10 January 2015")

iwlwifi 0000:01:00.0: loaded firmware version 23.11.10.0 op_mode iwlmvm
Loaded firmware version: 23.11.10.0

sha1sum iwl-3160-10.ucode cf1a39c1b30f389e12d17c1379a2ac539491b8e2
md5sum iwl-3160-10.ucode 9f744224cee51dac1d11708cade96641

If you need further infos, let me know!

> Anyway, make this change:
>
> diff --git a/drivers/net/wireless/iwlwifi/mvm/mvm.h b/drivers/net/wireless/iwlwifi/mvm/mvm.h
> index 979ac23522f2..5b8c969f457e 100644
> --- a/drivers/net/wireless/iwlwifi/mvm/mvm.h
> +++ b/drivers/net/wireless/iwlwifi/mvm/mvm.h
> @@ -874,7 +874,7 @@ static inline bool iwl_mvm_is_d0i3_supported(struct iwl_mvm *mvm)
>
>  static inline bool iwl_mvm_is_scd_cfg_supported(struct iwl_mvm *mvm)
>  {
> -       return mvm->fw->ucode_capa.capa[0] & IWL_UCODE_TLV_API_SCD_CFG;
> +       return false;
>  }
>
>  extern const u8 iwl_mvm_ac_to_tx_fifo[];
>
> I guess Emmanuel will look at it on Sunday :)
Thanks! That did the trick!

Regards,
   Christian
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Emmanuel Grumbach Jan. 31, 2015, 5:36 p.m. UTC | #2 
On Sat, 2015-01-31 at 15:16 +0100, Christian Lamparter wrote:
> Hello,

> 

> On Fri, Jan 30, 2015 at 9:35 PM, Johannes Berg

> <johannes@sipsolutions.net> wrote:

> > On Fri, 2015-01-30 at 21:23 +0100, Christian Lamparter wrote:

> >> [    6.274625] iwlwifi 0000:01:00.0: 0x00000038 | BAD_COMMAND

> >> [    6.275034] iwlwifi 0000:01:00.0: FW error in SYNC CMD SCD_QUEUE_CFG

> >

> > WTF. How did the firmware even announce support for this command??

> >

> > Perhaps I missed it in the log, but which firmware are you using? Any

> > chance you also upgraded that? Because I can't imagine this code is new

> > in the tree...

> Uhh, good question: I "think" got this firmware from one of Emmanuel's firmware

> announcements. (ls says "10 January 2015")

> 

> iwlwifi 0000:01:00.0: loaded firmware version 23.11.10.0 op_mode iwlmvm

> Loaded firmware version: 23.11.10.0

> 

> sha1sum iwl-3160-10.ucode cf1a39c1b30f389e12d17c1379a2ac539491b8e2

> md5sum iwl-3160-10.ucode 9f744224cee51dac1d11708cade96641

> 

> If you need further infos, let me know!

> 

> > Anyway, make this change:

> >

> > diff --git a/drivers/net/wireless/iwlwifi/mvm/mvm.h b/drivers/net/wireless/iwlwifi/mvm/mvm.h

> > index 979ac23522f2..5b8c969f457e 100644

> > --- a/drivers/net/wireless/iwlwifi/mvm/mvm.h

> > +++ b/drivers/net/wireless/iwlwifi/mvm/mvm.h

> > @@ -874,7 +874,7 @@ static inline bool iwl_mvm_is_d0i3_supported(struct iwl_mvm *mvm)

> >

> >  static inline bool iwl_mvm_is_scd_cfg_supported(struct iwl_mvm *mvm)

> >  {

> > -       return mvm->fw->ucode_capa.capa[0] & IWL_UCODE_TLV_API_SCD_CFG;

> > +       return false;

> >  }

> >

> >  extern const u8 iwl_mvm_ac_to_tx_fifo[];

> >

> > I guess Emmanuel will look at it on Sunday :)


Or earlier.

> Thanks! That did the trick!

> 


what about this:
https://git.kernel.org/cgit/linux/kernel/git/iwlwifi/iwlwifi-next.git/commit/?id=c774905d98badddbeb4ad1bc653aedbd7ab024e4

> Regards,

>    Christian
Christian Lamparter Jan. 31, 2015, 5:57 p.m. UTC | #3 
On Sat, Jan 31, 2015 at 6:36 PM, Grumbach, Emmanuel
<emmanuel.grumbach@intel.com> wrote:
> On Sat, 2015-01-31 at 15:16 +0100, Christian Lamparter wrote:
>> > I guess Emmanuel will look at it on Sunday :)
>
> Or earlier.
>
>> Thanks! That did the trick!
>>
>
> what about this:
> https://git.kernel.org/cgit/linux/kernel/git/iwlwifi/iwlwifi-next.git/commit/?id=c774905d98badddbeb4ad1bc653aedbd7ab024e4

Works.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/iwlwifi/mvm/mvm.h b/drivers/net/wireless/iwlwifi/mvm/mvm.h
index 979ac23522f2..5b8c969f457e 100644
--- a/drivers/net/wireless/iwlwifi/mvm/mvm.h
+++ b/drivers/net/wireless/iwlwifi/mvm/mvm.h
@@ -874,7 +874,7 @@  static inline bool iwl_mvm_is_d0i3_supported(struct iwl_mvm *mvm)
 
 static inline bool iwl_mvm_is_scd_cfg_supported(struct iwl_mvm *mvm)
 {
-	return mvm->fw->ucode_capa.capa[0] & IWL_UCODE_TLV_API_SCD_CFG;
+	return false;
 }
 
 extern const u8 iwl_mvm_ac_to_tx_fifo[];