| Message ID | 1425385230-25308-2-git-send-email-rmanohar@qti.qualcomm.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On 03/03/2015 04:20 AM, Rajkumar Manoharan wrote: > Since the station kickout threshold is also counting software > reries (Default sw count in firmware is 16), increasing the threshold > to try with already 20 data frames before kicking out the station. > > Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com> > --- > drivers/net/wireless/ath/ath10k/core.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h > index 7cba781..5a0b7cb 100644 > --- a/drivers/net/wireless/ath/ath10k/core.h > +++ b/drivers/net/wireless/ath/ath10k/core.h > @@ -50,8 +50,8 @@ > > #define ATH10K_MAX_NUM_MGMT_PENDING 128 > > -/* number of failed packets */ > -#define ATH10K_KICKOUT_THRESHOLD 50 > +/* number of failed packets (includes sw reties) */ > +#define ATH10K_KICKOUT_THRESHOLD (20 * 16) Maybe add comment about '20 packets with 16 retries each', so that users know what number is what? Thanks, Ben > > /* > * Use insanely high numbers to make sure that the firmware implementation >
diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h index 7cba781..5a0b7cb 100644 --- a/drivers/net/wireless/ath/ath10k/core.h +++ b/drivers/net/wireless/ath/ath10k/core.h @@ -50,8 +50,8 @@ #define ATH10K_MAX_NUM_MGMT_PENDING 128 -/* number of failed packets */ -#define ATH10K_KICKOUT_THRESHOLD 50 +/* number of failed packets (includes sw reties) */ +#define ATH10K_KICKOUT_THRESHOLD (20 * 16) /* * Use insanely high numbers to make sure that the firmware implementation
Since the station kickout threshold is also counting software reries (Default sw count in firmware is 16), increasing the threshold to try with already 20 data frames before kicking out the station. Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/core.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)