diff mbox

[1/3] wil6210: NAPI completion refactor

Message ID 1426428024-4538-2-git-send-email-qca_vkondrat@qca.qualcomm.com (mailing list archive)
State Rejected
Delegated to: Kalle Valo
Headers show

Commit Message

Vladimir Kondratiev March 15, 2015, 2 p.m. UTC 
It is expected that driver completes NAPI when less than
full budget is consumed.

Fulfill this requirement.

Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
---
 drivers/net/wireless/ath/wil6210/netdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Vladimir Kondratiev March 15, 2015, 2:03 p.m. UTC | #1 
On Sunday, March 15, 2015 04:00:15 PM Vladimir Kondratiev wrote:
> t is expected that driver completes NAPI when less than
> full budget is consumed.
> 
> Fulfill this requirement.
> 
> Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
> 
Please ignore, old patch, sent by mistake.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kalle Valo March 16, 2015, 6:20 a.m. UTC | #2 
Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com> writes:

> On Sunday, March 15, 2015 04:00:15 PM Vladimir Kondratiev wrote:
>> t is expected that driver completes NAPI when less than
>> full budget is consumed.
>> 
>> Fulfill this requirement.
>> 
>> Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
>> 
> Please ignore, old patch, sent by mistake.

Ok, I dropped the three old patches from my queue.
diff mbox

Patch

diff --git a/drivers/net/wireless/ath/wil6210/netdev.c b/drivers/net/wireless/ath/wil6210/netdev.c
index ace30c1..f2f7ea2 100644
--- a/drivers/net/wireless/ath/wil6210/netdev.c
+++ b/drivers/net/wireless/ath/wil6210/netdev.c
@@ -82,7 +82,7 @@  static int wil6210_netdev_poll_rx(struct napi_struct *napi, int budget)
 	wil_rx_handle(wil, &quota);
 	done = budget - quota;
 
-	if (done <= 1) { /* burst ends - only one packet processed */
+	if (done < budget) {
 		napi_complete(napi);
 		wil6210_unmask_irq_rx(wil);
 		wil_dbg_txrx(wil, "NAPI RX complete\n");
@@ -110,7 +110,7 @@  static int wil6210_netdev_poll_tx(struct napi_struct *napi, int budget)
 		tx_done += wil_tx_complete(wil, i);
 	}
 
-	if (tx_done <= 1) { /* burst ends - only one packet processed */
+	if (tx_done < budget) {
 		napi_complete(napi);
 		wil6210_unmask_irq_tx(wil);
 		wil_dbg_txrx(wil, "NAPI TX complete\n");