| Message ID | 1426701700-21974-1-git-send-email-arnagara@qti.qualcomm.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
Ashok Raj Nagarajan <arnagara@qti.qualcomm.com> writes: > ANI is currently not enabled by default. Enable this feature by default. > > Signed-off-by: Ashok Raj Nagarajan <arnagara@qti.qualcomm.com> You did not send this to ath10k list (and CC linux-wireless). Check the instructions here: https://wireless.wiki.kernel.org/en/users/drivers/ath10k/sources#submitting_patches Also the commit log doesn't tell anything. What is ANI and why should it be enabled? What bug does this fix (if any)? How will the user see the difference after this patch is applied? As a rule of thumb, the commit log should tell any engineer (even one who is not familiar with ath10k) how the behaviour changes after the patch is applied. Think of your target group being distro maintainers, ath10k users, kernel subsystem maintainers etc. No company internal jargon or anything like that, write in plain english so that everyone understand.
Kalle Valo <kvalo@qca.qualcomm.com> writes: > Ashok Raj Nagarajan <arnagara@qti.qualcomm.com> writes: > >> ANI is currently not enabled by default. Enable this feature by default. >> >> Signed-off-by: Ashok Raj Nagarajan <arnagara@qti.qualcomm.com> > > You did not send this to ath10k list (and CC linux-wireless). Check the > instructions here: > > https://wireless.wiki.kernel.org/en/users/drivers/ath10k/sources#submitting_patches > > Also the commit log doesn't tell anything. What is ANI and why should it > be enabled? What bug does this fix (if any)? How will the user see the > difference after this patch is applied? > > As a rule of thumb, the commit log should tell any engineer (even one > who is not familiar with ath10k) how the behaviour changes after the > patch is applied. Think of your target group being distro maintainers, > ath10k users, kernel subsystem maintainers etc. No company internal > jargon or anything like that, write in plain english so that everyone > understand. I also forgot to CC ath10k list.
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 0f39af7..380d4b1 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -2896,6 +2896,14 @@ static int ath10k_start(struct ieee80211_hw *hw) goto err_core_stop; } + ret = ath10k_wmi_pdev_set_param(ar, + ar->wmi.pdev_param->ani_enable, 1); + if (ret) { + ath10k_warn(ar, "failed to enable ani by default: %d\n", + ret); + goto err_core_stop; + } + ar->num_started_vdevs = 0; ath10k_regd_update(ar);
ANI is currently not enabled by default. Enable this feature by default. Signed-off-by: Ashok Raj Nagarajan <arnagara@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/mac.c | 8 ++++++++ 1 file changed, 8 insertions(+)