diff mbox

afs: kstrdup() memory handling

Message ID 1426956609-27273-1-git-send-email-sanidhya.gatech@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Sanidhya Kashyap March 21, 2015, 4:50 p.m. UTC 
Handling kstrdup() failure in case of memory pressure even
for new_opts.

Signed-off-by: Sanidhya Kashyap <sanidhya.gatech@gmail.com>
---
 fs/afs/super.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Jeff Epler March 21, 2015, 5:07 p.m. UTC | #1 
On Sat, Mar 21, 2015 at 12:50:09PM -0400, Sanidhya Kashyap wrote:
> +	if (new_opts)
> +		goto error_out;

Missing "!"?

Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sanidhya Kashyap March 21, 2015, 5:11 p.m. UTC | #2 
On Sat, Mar 21, 2015 at 1:07 PM, Jeff Epler <jepler@unpythonic.net> wrote:
> On Sat, Mar 21, 2015 at 12:50:09PM -0400, Sanidhya Kashyap wrote:
>> +     if (new_opts)
>> +             goto error_out;
>
> Missing "!"?
>

Ohh! Sorry, missed it!

Resending the patch?

Thanks,
Sanidhya

> Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/afs/super.c b/fs/afs/super.c
index c486155..477f38e 100644
--- a/fs/afs/super.c
+++ b/fs/afs/super.c
@@ -360,10 +360,13 @@  static struct dentry *afs_mount(struct file_system_type *fs_type,
 	struct key *key;
 	char *new_opts = kstrdup(options, GFP_KERNEL);
 	struct afs_super_info *as;
-	int ret;
+	int ret = -ENOMEM;
 
 	_enter(",,%s,%p", dev_name, options);
 
+	if (new_opts)
+		goto error_out;
+
 	memset(&params, 0, sizeof(params));
 
 	ret = -EINVAL;
@@ -441,6 +444,7 @@  error:
 	afs_put_cell(params.cell);
 	key_put(params.key);
 	kfree(new_opts);
+error_out:
 	_leave(" = %d", ret);
 	return ERR_PTR(ret);
 }