diff mbox

[1/3] IB/netlink: Add defines for MAD requests through netlink

Message ID 1431975616-23529-2-git-send-email-kaike.wan@intel.com (mailing list archive)
State Superseded
Headers show

Commit Message

Wan, Kaike May 18, 2015, 7 p.m. UTC 
From: Kaike Wan <kaike.wan@intel.com>

This patch adds netlink defines for MAD client, MAD group, and MAD
operation.

Signed-off-by: Kaike Wan <kaike.wan@intel.com>
Signed-off-by: John Fleck <john.fleck@intel.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Sean Hefty <sean.hefty@intel.com>
---
 include/uapi/rdma/rdma_netlink.h |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

Comments

Or Gerlitz May 19, 2015, 5:36 a.m. UTC | #1 
On Mon, May 18, 2015 at 10:00 PM,  <kaike.wan@intel.com> wrote:
> From: Kaike Wan <kaike.wan@intel.com>
>
> This patch adds netlink defines for MAD client, MAD group, and MAD
> operation.

But you added code that deals specifically with SA things, not general
mads, right? better to reflect that
is the name and use RDMA_NL_SA prefix
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Wan, Kaike May 19, 2015, 11:38 a.m. UTC | #2 
> 

> On Mon, May 18, 2015 at 10:00 PM,  <kaike.wan@intel.com> wrote:

> > From: Kaike Wan <kaike.wan@intel.com>

> >

> > This patch adds netlink defines for MAD client, MAD group, and MAD

> > operation.

> 

> But you added code that deals specifically with SA things, not general mads,

> right? better to reflect that is the name and use RDMA_NL_SA prefix



It's true that we are dealing with SA pathrecord query in the end. However, the netlink mechanism is more general than SA specific: it's more about communication between the kernel and the user-space with a MAD packet through the netlink. The mechanism could be easily extended to other MAD requests. The SA pathrecord query is just an specific use of this mechanism.

Originally we did use RDMA_NL_SA prefix.

Kaike
diff mbox

Patch

diff --git a/include/uapi/rdma/rdma_netlink.h b/include/uapi/rdma/rdma_netlink.h
index 6e4bb42..c747453 100644
--- a/include/uapi/rdma/rdma_netlink.h
+++ b/include/uapi/rdma/rdma_netlink.h
@@ -7,12 +7,14 @@  enum {
 	RDMA_NL_RDMA_CM = 1,
 	RDMA_NL_NES,
 	RDMA_NL_C4IW,
+	RDMA_NL_MAD,
 	RDMA_NL_NUM_CLIENTS
 };
 
 enum {
 	RDMA_NL_GROUP_CM = 1,
 	RDMA_NL_GROUP_IWPM,
+	RDMA_NL_GROUP_MAD,
 	RDMA_NL_NUM_GROUPS
 };
 
@@ -44,6 +46,11 @@  enum {
 	RDMA_NL_IWPM_NUM_OPS
 };
 
+enum {
+	RDMA_NL_MAD_REQUEST = 0,
+	RDMA_NL_MAD_NUM_OPS
+};
+
 struct rdma_cm_id_stats {
 	__u32	qp_num;
 	__u32	bound_dev_if;