| Message ID | 1434126678-7978-6-git-send-email-ricardo.ribalda@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Sylwester, Can you confirm that this is only used with bridge drivers that use the control framework? Actually, this driver isn't used by any bridge driver in the kernel tree, but it is probably in use by out-of-tree code. I'd like your Ack (or Nack) before I merge this. Note that eventually these legacy support ops will disappear once all bridge drivers in the kernel have been converted to the control framework. Regards, Hans On 06/12/2015 06:31 PM, Ricardo Ribalda Delgado wrote: > They are no longer used in old non-control-framework > bridge drivers. > > Reported-by: Hans Verkuil <hans.verkuil@cisco.com> > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> > --- > drivers/media/i2c/sr030pc30.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/media/i2c/sr030pc30.c b/drivers/media/i2c/sr030pc30.c > index b62b6ddc4356..229dc76c44a5 100644 > --- a/drivers/media/i2c/sr030pc30.c > +++ b/drivers/media/i2c/sr030pc30.c > @@ -636,13 +636,6 @@ static const struct v4l2_ctrl_ops sr030pc30_ctrl_ops = { > > static const struct v4l2_subdev_core_ops sr030pc30_core_ops = { > .s_power = sr030pc30_s_power, > - .g_ext_ctrls = v4l2_subdev_g_ext_ctrls, > - .try_ext_ctrls = v4l2_subdev_try_ext_ctrls, > - .s_ext_ctrls = v4l2_subdev_s_ext_ctrls, > - .g_ctrl = v4l2_subdev_g_ctrl, > - .s_ctrl = v4l2_subdev_s_ctrl, > - .queryctrl = v4l2_subdev_queryctrl, > - .querymenu = v4l2_subdev_querymenu, > }; > > static const struct v4l2_subdev_pad_ops sr030pc30_pad_ops = { > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Hans, On 15/06/15 12:23, Hans Verkuil wrote: > Sylwester, > > Can you confirm that this is only used with bridge drivers that use the > control framework? Actually, this driver isn't used by any bridge driver > in the kernel tree, but it is probably in use by out-of-tree code. > > I'd like your Ack (or Nack) before I merge this. > > Note that eventually these legacy support ops will disappear once all > bridge drivers in the kernel have been converted to the control framework. This sensor driver is used on board type which has been scratched long time ago, feel free to do any changes in this code. Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
diff --git a/drivers/media/i2c/sr030pc30.c b/drivers/media/i2c/sr030pc30.c index b62b6ddc4356..229dc76c44a5 100644 --- a/drivers/media/i2c/sr030pc30.c +++ b/drivers/media/i2c/sr030pc30.c @@ -636,13 +636,6 @@ static const struct v4l2_ctrl_ops sr030pc30_ctrl_ops = { static const struct v4l2_subdev_core_ops sr030pc30_core_ops = { .s_power = sr030pc30_s_power, - .g_ext_ctrls = v4l2_subdev_g_ext_ctrls, - .try_ext_ctrls = v4l2_subdev_try_ext_ctrls, - .s_ext_ctrls = v4l2_subdev_s_ext_ctrls, - .g_ctrl = v4l2_subdev_g_ctrl, - .s_ctrl = v4l2_subdev_s_ctrl, - .queryctrl = v4l2_subdev_queryctrl, - .querymenu = v4l2_subdev_querymenu, }; static const struct v4l2_subdev_pad_ops sr030pc30_pad_ops = {
They are no longer used in old non-control-framework bridge drivers. Reported-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> --- drivers/media/i2c/sr030pc30.c | 7 ------- 1 file changed, 7 deletions(-)