| Message ID | 1434653006-5693-5-git-send-email-rodrigo.vivi@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2015-06-18 15:43 GMT-03:00 Rodrigo Vivi <rodrigo.vivi@intel.com>: > With a reliable frontbuffer tracking and all instability corner cases solved > let's re-enabled PSR by default on all supported platforms. Are we now passing all the PSR tests from kms_frontbuffer_tracking too? > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > drivers/gpu/drm/i915/i915_params.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > index 8ac5a1b..e864e67 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -37,7 +37,7 @@ struct i915_params i915 __read_mostly = { > .enable_execlists = -1, > .enable_hangcheck = true, > .enable_ppgtt = -1, > - .enable_psr = 0, > + .enable_psr = 1, > .preliminary_hw_support = IS_ENABLED(CONFIG_DRM_I915_PRELIMINARY_HW_SUPPORT), > .disable_power_well = 1, > .enable_ips = 1, > @@ -124,7 +124,7 @@ MODULE_PARM_DESC(enable_execlists, > "(-1=auto [default], 0=disabled, 1=enabled)"); > > module_param_named(enable_psr, i915.enable_psr, int, 0600); > -MODULE_PARM_DESC(enable_psr, "Enable PSR (default: false)"); > +MODULE_PARM_DESC(enable_psr, "Enable PSR (default: true)"); > > module_param_named(preliminary_hw_support, i915.preliminary_hw_support, int, 0600); > MODULE_PARM_DESC(preliminary_hw_support, > -- > 2.1.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
2015-06-18 15:54 GMT-03:00 Paulo Zanoni <przanoni@gmail.com>: > 2015-06-18 15:43 GMT-03:00 Rodrigo Vivi <rodrigo.vivi@intel.com>: >> With a reliable frontbuffer tracking and all instability corner cases solved >> let's re-enabled PSR by default on all supported platforms. > > Are we now passing all the PSR tests from kms_frontbuffer_tracking too? Ok so I discussed this with Rodrigo today, and all the failures I was seeing were due to bugs on the test suite. I have local IGT fixes for these failures, and I could verify that, with those fixes, all the current tests pass on the current -nightly tree (i.e., I'm not testing this patch series!). > >> >> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> >> --- >> drivers/gpu/drm/i915/i915_params.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c >> index 8ac5a1b..e864e67 100644 >> --- a/drivers/gpu/drm/i915/i915_params.c >> +++ b/drivers/gpu/drm/i915/i915_params.c >> @@ -37,7 +37,7 @@ struct i915_params i915 __read_mostly = { >> .enable_execlists = -1, >> .enable_hangcheck = true, >> .enable_ppgtt = -1, >> - .enable_psr = 0, >> + .enable_psr = 1, >> .preliminary_hw_support = IS_ENABLED(CONFIG_DRM_I915_PRELIMINARY_HW_SUPPORT), >> .disable_power_well = 1, >> .enable_ips = 1, >> @@ -124,7 +124,7 @@ MODULE_PARM_DESC(enable_execlists, >> "(-1=auto [default], 0=disabled, 1=enabled)"); >> >> module_param_named(enable_psr, i915.enable_psr, int, 0600); >> -MODULE_PARM_DESC(enable_psr, "Enable PSR (default: false)"); >> +MODULE_PARM_DESC(enable_psr, "Enable PSR (default: true)"); >> >> module_param_named(preliminary_hw_support, i915.preliminary_hw_support, int, 0600); >> MODULE_PARM_DESC(preliminary_hw_support, >> -- >> 2.1.0 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > -- > Paulo Zanoni
On Wed, 2015-06-24 at 18:48 -0300, Paulo Zanoni wrote: > 2015-06-18 15:54 GMT-03:00 Paulo Zanoni <przanoni@gmail.com>: > > 2015-06-18 15:43 GMT-03:00 Rodrigo Vivi <rodrigo.vivi@intel.com>: > >> With a reliable frontbuffer tracking and all instability corner cases solved > >> let's re-enabled PSR by default on all supported platforms. > > > > Are we now passing all the PSR tests from kms_frontbuffer_tracking too? > > Ok so I discussed this with Rodrigo today, and all the failures I was > seeing were due to bugs on the test suite. I have local IGT fixes for > these failures, and I could verify that, with those fixes, all the > current tests pass on the current -nightly tree (i.e., I'm not testing > this patch series!). Thanks Paulo. Nevermind about this series... you were right... this series would break all tests anyway... ;) > > > > >> > >> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > >> --- > >> drivers/gpu/drm/i915/i915_params.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > >> index 8ac5a1b..e864e67 100644 > >> --- a/drivers/gpu/drm/i915/i915_params.c > >> +++ b/drivers/gpu/drm/i915/i915_params.c > >> @@ -37,7 +37,7 @@ struct i915_params i915 __read_mostly = { > >> .enable_execlists = -1, > >> .enable_hangcheck = true, > >> .enable_ppgtt = -1, > >> - .enable_psr = 0, > >> + .enable_psr = 1, > >> .preliminary_hw_support = IS_ENABLED(CONFIG_DRM_I915_PRELIMINARY_HW_SUPPORT), > >> .disable_power_well = 1, > >> .enable_ips = 1, > >> @@ -124,7 +124,7 @@ MODULE_PARM_DESC(enable_execlists, > >> "(-1=auto [default], 0=disabled, 1=enabled)"); > >> > >> module_param_named(enable_psr, i915.enable_psr, int, 0600); > >> -MODULE_PARM_DESC(enable_psr, "Enable PSR (default: false)"); > >> +MODULE_PARM_DESC(enable_psr, "Enable PSR (default: true)"); > >> > >> module_param_named(preliminary_hw_support, i915.preliminary_hw_support, int, 0600); > >> MODULE_PARM_DESC(preliminary_hw_support, > >> -- > >> 2.1.0 > >> > >> _______________________________________________ > >> Intel-gfx mailing list > >> Intel-gfx@lists.freedesktop.org > >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > > > > > -- > > Paulo Zanoni > > >
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 8ac5a1b..e864e67 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_params.c @@ -37,7 +37,7 @@ struct i915_params i915 __read_mostly = { .enable_execlists = -1, .enable_hangcheck = true, .enable_ppgtt = -1, - .enable_psr = 0, + .enable_psr = 1, .preliminary_hw_support = IS_ENABLED(CONFIG_DRM_I915_PRELIMINARY_HW_SUPPORT), .disable_power_well = 1, .enable_ips = 1, @@ -124,7 +124,7 @@ MODULE_PARM_DESC(enable_execlists, "(-1=auto [default], 0=disabled, 1=enabled)"); module_param_named(enable_psr, i915.enable_psr, int, 0600); -MODULE_PARM_DESC(enable_psr, "Enable PSR (default: false)"); +MODULE_PARM_DESC(enable_psr, "Enable PSR (default: true)"); module_param_named(preliminary_hw_support, i915.preliminary_hw_support, int, 0600); MODULE_PARM_DESC(preliminary_hw_support,
With a reliable frontbuffer tracking and all instability corner cases solved let's re-enabled PSR by default on all supported platforms. Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> --- drivers/gpu/drm/i915/i915_params.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)