[11/12] f2fs: add noextent_cache mount option

Commit Message

Jaegeuk Kim June 29, 2015, 6:39 p.m. UTC

This patch adds noextent_cache mount option.

Signed-off-by: Jaegeuk Kim <[e-mail]>
---
 fs/f2fs/super.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Chao Yu July 2, 2015, 12:35 p.m. UTC | #1

> -----Original Message-----
> From: Jaegeuk Kim [mailto:[e-mail]]
> Sent: Tuesday, June 30, 2015 2:40 AM
> To: [e-mail]; [e-mail];
> [e-mail]
> Cc: Jaegeuk Kim
> Subject: [f2fs-dev] [PATCH 11/12] f2fs: add noextent_cache mount option
> 
> This patch adds noextent_cache mount option.

How about adding some descriptions in Documentation to help our user?

The other thing is we'd better to show 'noextent_cache' option when user
lookups the mount options.

How about adding codes as below?
if (test_opt(sbi, EXTENT_CACHE))
	seq_puts(seq, ",extent_cache");
+else
+	seq_puts(seq, ",noextent_cache");

> 
> Signed-off-by: Jaegeuk Kim <[e-mail]>

The other looks good to me, so please add:

Reviewed-by: Chao Yu <[e-mail]>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Jaegeuk Kim July 4, 2015, 4:57 a.m. UTC | #2

On Thu, Jul 02, 2015 at 08:35:34PM +0800, Chao Yu wrote:
> > -----Original Message-----
> > From: Jaegeuk Kim [mailto:[e-mail]]
> > Sent: Tuesday, June 30, 2015 2:40 AM
> > To: [e-mail]; [e-mail];
> > [e-mail]
> > Cc: Jaegeuk Kim
> > Subject: [f2fs-dev] [PATCH 11/12] f2fs: add noextent_cache mount option
> > 
> > This patch adds noextent_cache mount option.
> 
> How about adding some descriptions in Documentation to help our user?
> 
> The other thing is we'd better to show 'noextent_cache' option when user
> lookups the mount options.
> 
> How about adding codes as below?
> if (test_opt(sbi, EXTENT_CACHE))
> 	seq_puts(seq, ",extent_cache");
> +else
> +	seq_puts(seq, ",noextent_cache");
> 

Agreed.

Thanks,

> > 
> > Signed-off-by: Jaegeuk Kim <[e-mail]>
> 
> The other looks good to me, so please add:
> 
> Reviewed-by: Chao Yu <[e-mail]>
> 
> ------------------------------------------------------------------------------
> Don't Limit Your Business. Reach for the Cloud.
> GigeNET's Cloud Solutions provide you with the tools and support that
> you need to offload your IT needs and focus on growing your business.
> Configured For All Businesses. Start Your Cloud Today.
> https://www.gigenetcloud.com/
> _______________________________________________
> Linux-f2fs-devel mailing list
> [e-mail]
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 2e8645e..a9db896 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -65,6 +65,7 @@  enum {
 	Opt_nobarrier,
 	Opt_fastboot,
 	Opt_extent_cache,
+	Opt_noextent_cache,
 	Opt_noinline_data,
 	Opt_err,
 };
@@ -88,6 +89,7 @@  static match_table_t f2fs_tokens = {
 	{Opt_nobarrier, "nobarrier"},
 	{Opt_fastboot, "fastboot"},
 	{Opt_extent_cache, "extent_cache"},
+	{Opt_noextent_cache, "noextent_cache"},
 	{Opt_noinline_data, "noinline_data"},
 	{Opt_err, NULL},
 };
@@ -389,6 +391,9 @@  static int parse_options(struct super_block *sb, char *options)
 		case Opt_extent_cache:
 			set_opt(sbi, EXTENT_CACHE);
 			break;
+		case Opt_noextent_cache:
+			clear_opt(sbi, EXTENT_CACHE);
+			break;
 		case Opt_noinline_data:
 			clear_opt(sbi, INLINE_DATA);
 			break;