| Message ID | 1437075444-6779-1-git-send-email-kevin@darbyshire-bryant.me.uk (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes: > When using DFS channels on Ath10k kernel log has warning message 'failed > to process fft', typically when under medium/heavy traffic. Ticket > https://dev.openwrt.org/ticket/19316 discusses and concludes messages > are harmless. They do still contribute to log noise, so this patch > enables them only in driver debug mode. > > Signed-off-by: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> Don't reference to a discussion somewhere else with a link, instead summarise the discussion in the commit log. And please change the title to: ath10k: suppress 'failed to process fft' warning messages. Also please CC linux-wireless list as instructed here: https://wireless.wiki.kernel.org/en/users/drivers/ath10k/sources#submitting_patches
On 21/07/15 13:04, Kalle Valo wrote: > Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes: > >> When using DFS channels on Ath10k kernel log has warning message 'failed >> to process fft', typically when under medium/heavy traffic. Ticket >> https://dev.openwrt.org/ticket/19316 discusses and concludes messages >> are harmless. They do still contribute to log noise, so this patch >> enables them only in driver debug mode. >> >> Signed-off-by: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> > Don't reference to a discussion somewhere else with a link, instead > summarise the discussion in the commit log. > > And please change the title to: ath10k: suppress 'failed to process fft' > warning messages. Also please CC linux-wireless list as instructed here: > > https://wireless.wiki.kernel.org/en/users/drivers/ath10k/sources#submitting_patches > Hi Kalle, Thanks for your feedback. Sent again with requested changes. Best I can do, so hopefully good enough. Cheers, Kevin
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 0791a43..1435614 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -3498,7 +3498,7 @@ void ath10k_wmi_event_spectral_scan(struct ath10k *ar, fftr, fftr_len, tsf); if (res < 0) { - ath10k_warn(ar, "failed to process fft report: %d\n", + ath10k_dbg(ar, ATH10K_DBG_WMI, "failed to process fft report: %d\n", res); return; }
When using DFS channels on Ath10k kernel log has warning message 'failed to process fft', typically when under medium/heavy traffic. Ticket https://dev.openwrt.org/ticket/19316 discusses and concludes messages are harmless. They do still contribute to log noise, so this patch enables them only in driver debug mode. Signed-off-by: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> --- drivers/net/wireless/ath/ath10k/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)