| Message ID | 1437570061-29126-1-git-send-email-sivakumar.thulasimani@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 6848
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
ILK 295/295 295/295
SNB 315/315 315/315
IVB 342/342 342/342
BYT 285/285 285/285
HSW 378/380 378/380
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
Note: You need to pay more attention to line start with '*'
Any comments for this change ? On 7/22/2015 6:31 PM, Sivakumar Thulasimani wrote: > From: "Thulasimani,Sivakumar" <sivakumar.thulasimani@intel.com> > > DP spec requires the checksum of the last block read to be written > when replying to TEST_EDID_READ. This patch fixes the current code > to do the same. > > Signed-off-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com> > --- > drivers/gpu/drm/i915/intel_dp.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index f1b9f93..fa6e202 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -4090,9 +4090,16 @@ static uint8_t intel_dp_autotest_edid(struct intel_dp *intel_dp) > intel_dp->aux.i2c_defer_count); > intel_dp->compliance_test_data = INTEL_DP_RESOLUTION_FAILSAFE; > } else { > + struct edid *block = intel_connector->detect_edid; > + > + /* We have to write the checksum > + * of the last block read > + */ > + block += intel_connector->detect_edid->extensions; > + > if (!drm_dp_dpcd_write(&intel_dp->aux, > DP_TEST_EDID_CHECKSUM, > - &intel_connector->detect_edid->checksum, > + &block->checksum, > 1)) > DRM_DEBUG_KMS("Failed to write EDID checksum\n"); >
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index f1b9f93..fa6e202 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -4090,9 +4090,16 @@ static uint8_t intel_dp_autotest_edid(struct intel_dp *intel_dp) intel_dp->aux.i2c_defer_count); intel_dp->compliance_test_data = INTEL_DP_RESOLUTION_FAILSAFE; } else { + struct edid *block = intel_connector->detect_edid; + + /* We have to write the checksum + * of the last block read + */ + block += intel_connector->detect_edid->extensions; + if (!drm_dp_dpcd_write(&intel_dp->aux, DP_TEST_EDID_CHECKSUM, - &intel_connector->detect_edid->checksum, + &block->checksum, 1)) DRM_DEBUG_KMS("Failed to write EDID checksum\n");