| Message ID | 1437987388-9706-6-git-send-email-lars@metafoo.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 85cf604edc18722140f73e225394722801e55de0 |
| Headers | show |
Hi, On 07/27/2015 10:56 AM, Lars-Peter Clausen wrote: > uni_player_dai_ops is not used outside of this file so it should be static. > Fixes the following sparse warning: > > sound/soc/sti/uniperif_player.c:959:30: warning: symbol > 'uni_player_dai_ops' was not declared. Should it be static? > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> > --- Thanks for this one also acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com> Br Arnaud
diff --git a/sound/soc/sti/uniperif_player.c b/sound/soc/sti/uniperif_player.c index f609089..d8df906 100644 --- a/sound/soc/sti/uniperif_player.c +++ b/sound/soc/sti/uniperif_player.c @@ -956,7 +956,7 @@ static int uni_player_parse_dt(struct platform_device *pdev, return 0; } -const struct snd_soc_dai_ops uni_player_dai_ops = { +static const struct snd_soc_dai_ops uni_player_dai_ops = { .startup = uni_player_startup, .shutdown = uni_player_shutdown, .prepare = uni_player_prepare,
uni_player_dai_ops is not used outside of this file so it should be static. Fixes the following sparse warning: sound/soc/sti/uniperif_player.c:959:30: warning: symbol 'uni_player_dai_ops' was not declared. Should it be static? Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> --- sound/soc/sti/uniperif_player.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)