| Message ID | 1437986294-6697-1-git-send-email-hariprasad@chelsio.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 07/27/2015 04:38 AM, Hariprasad Shenai wrote: > c4iw_poll_cq_on() shouldn't fail the poll operation just because > the CQE status is unknown. Rather, it should map this to the > "fatal error" status and log the anomaly. > > Signed-off-by: Steve Wise <swise@opengridcomputing.com> > Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com> > --- > drivers/infiniband/hw/cxgb4/cq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/cxgb4/cq.c b/drivers/infiniband/hw/cxgb4/cq.c > index c7aab48..92d5183 100644 > --- a/drivers/infiniband/hw/cxgb4/cq.c > +++ b/drivers/infiniband/hw/cxgb4/cq.c > @@ -814,7 +814,7 @@ static int c4iw_poll_cq_one(struct c4iw_cq *chp, struct ib_wc *wc) > printk(KERN_ERR MOD > "Unexpected cqe_status 0x%x for QPID=0x%0x\n", > CQE_STATUS(&cqe), CQE_QPID(&cqe)); > - ret = -EINVAL; > + wc->status = IB_WC_FATAL_ERR; > } > } > out: > Accepted for 4.2-rc.
diff --git a/drivers/infiniband/hw/cxgb4/cq.c b/drivers/infiniband/hw/cxgb4/cq.c index c7aab48..92d5183 100644 --- a/drivers/infiniband/hw/cxgb4/cq.c +++ b/drivers/infiniband/hw/cxgb4/cq.c @@ -814,7 +814,7 @@ static int c4iw_poll_cq_one(struct c4iw_cq *chp, struct ib_wc *wc) printk(KERN_ERR MOD "Unexpected cqe_status 0x%x for QPID=0x%0x\n", CQE_STATUS(&cqe), CQE_QPID(&cqe)); - ret = -EINVAL; + wc->status = IB_WC_FATAL_ERR; } } out: