| Message ID | 1440002254-795-4-git-send-email-hch@lst.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Wed, Aug 19, 2015 at 06:37:34PM +0200, Christoph Hellwig wrote: > The field is only initialized in mlx, but never used. > > If we want to add proper XRC support it should be done with a new > struct ib_xrc_wr. > > This shrinks the various WR structures by another 4 bytes. Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> I've never really been entirely clear on how much of this stuff needs to be kernel side. Even the switch doesn't really make alot of sense.. > +++ b/drivers/infiniband/hw/mlx5/qp.c > @@ -2634,7 +2634,6 @@ int mlx5_ib_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr, > switch (ibqp->qp_type) { > case IB_QPT_XRC_INI: > xrc = seg; > - xrc->xrc_srqn = htonl(wr->xrc_remote_srq_num); Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 8/19/2015 7:37 PM, Christoph Hellwig wrote: > The field is only initialized in mlx, but never used. > > If we want to add proper XRC support it should be done with a new > struct ib_xrc_wr. > > This shrinks the various WR structures by another 4 bytes. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > drivers/infiniband/hw/mlx5/qp.c | 1 - > include/rdma/ib_verbs.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c > index 04df156..83a290f 100644 > --- a/drivers/infiniband/hw/mlx5/qp.c > +++ b/drivers/infiniband/hw/mlx5/qp.c > @@ -2634,7 +2634,6 @@ int mlx5_ib_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr, > switch (ibqp->qp_type) { > case IB_QPT_XRC_INI: > xrc = seg; > - xrc->xrc_srqn = htonl(wr->xrc_remote_srq_num); > seg += sizeof(*xrc); > size += sizeof(*xrc) / 16; > /* fall through */ > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h > index 9b29c78..b855189 100644 > --- a/include/rdma/ib_verbs.h > +++ b/include/rdma/ib_verbs.h > @@ -1100,7 +1100,6 @@ struct ib_send_wr { > __be32 imm_data; > u32 invalidate_rkey; > } ex; > - u32 xrc_remote_srq_num; /* XRC TGT QPs only */ > }; > > struct ib_rdma_wr { > Looks OK to me, Reviewed-by: Sagi Grimberg <sagig@mellanox.com> This will need Eli's ack though... -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index 04df156..83a290f 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -2634,7 +2634,6 @@ int mlx5_ib_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr, switch (ibqp->qp_type) { case IB_QPT_XRC_INI: xrc = seg; - xrc->xrc_srqn = htonl(wr->xrc_remote_srq_num); seg += sizeof(*xrc); size += sizeof(*xrc) / 16; /* fall through */ diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 9b29c78..b855189 100644 --- a/include/rdma/ib_verbs.h +++ b/include/rdma/ib_verbs.h @@ -1100,7 +1100,6 @@ struct ib_send_wr { __be32 imm_data; u32 invalidate_rkey; } ex; - u32 xrc_remote_srq_num; /* XRC TGT QPs only */ }; struct ib_rdma_wr {
The field is only initialized in mlx, but never used. If we want to add proper XRC support it should be done with a new struct ib_xrc_wr. This shrinks the various WR structures by another 4 bytes. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/infiniband/hw/mlx5/qp.c | 1 - include/rdma/ib_verbs.h | 1 - 2 files changed, 2 deletions(-)