| Message ID | 1444124541-5663-2-git-send-email-tony.cho@atmel.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
On Tue, Oct 06, 2015 at 06:42:13PM +0900, Tony Cho wrote: > From: Leo Kim <leo.kim@atmel.com> > > This patch remove typedef from the enum tenuWIDtype > and rename it to WID_TYPE. > > Signed-off-by: Leo Kim <leo.kim@atmel.com> > Signed-off-by: Tony Cho <tony.cho@atmel.com> > --- > drivers/staging/wilc1000/coreconfigurator.h | 2 +- > drivers/staging/wilc1000/host_interface.h | 2 +- > drivers/staging/wilc1000/wilc_wlan_if.h | 5 ++--- > 3 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h > index 306efc9..02faf58 100644 [ snip ] > diff --git a/drivers/staging/wilc1000/wilc_wlan_if.h b/drivers/staging/wilc1000/wilc_wlan_if.h > index 8fec64d..be972af 100644 > --- a/drivers/staging/wilc1000/wilc_wlan_if.h > +++ b/drivers/staging/wilc1000/wilc_wlan_if.h > @@ -315,7 +315,7 @@ typedef enum { > SW_TRIGGER_ABORT, > } TX_ABORT_OPTION_T; > > -typedef enum { > +enum WID_TYPE { The enum name should be lowecase, i.e. 'enum wid_type'. > WID_CHAR = 0, > WID_SHORT = 1, > WID_INT = 2, > @@ -326,8 +326,7 @@ typedef enum { > WID_ADR = 7, > WID_UNDEF = 8, > WID_TYPE_FORCE_32BIT = 0xFFFFFFFF > - > -} WID_TYPE_T, tenuWIDtype; > +}; > > typedef enum { > WID_NIL = 0xffff, > -- > 1.9.1 -- Sincerely yours, Mike. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2015? 10? 07? 00:14, Mike Rapoport wrote: > On Tue, Oct 06, 2015 at 06:42:13PM +0900, Tony Cho wrote: >> From: Leo Kim <leo.kim@atmel.com> >> >> This patch remove typedef from the enum tenuWIDtype >> and rename it to WID_TYPE. >> >> Signed-off-by: Leo Kim <leo.kim@atmel.com> >> Signed-off-by: Tony Cho <tony.cho@atmel.com> >> --- >> drivers/staging/wilc1000/coreconfigurator.h | 2 +- >> drivers/staging/wilc1000/host_interface.h | 2 +- >> drivers/staging/wilc1000/wilc_wlan_if.h | 5 ++--- >> 3 files changed, 4 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h >> index 306efc9..02faf58 100644 > [ snip ] > >> diff --git a/drivers/staging/wilc1000/wilc_wlan_if.h b/drivers/staging/wilc1000/wilc_wlan_if.h >> index 8fec64d..be972af 100644 >> --- a/drivers/staging/wilc1000/wilc_wlan_if.h >> +++ b/drivers/staging/wilc1000/wilc_wlan_if.h >> @@ -315,7 +315,7 @@ typedef enum { >> SW_TRIGGER_ABORT, >> } TX_ABORT_OPTION_T; >> >> -typedef enum { >> +enum WID_TYPE { > The enum name should be lowecase, i.e. 'enum wid_type'. > All of enumerated types aren't uppercase. Can we mark outstanding enumeration with uppercase in specific file? If this doesn't violate any rules in Linux coding style, I want to go as it did. Thanks for your advice, Tony. >> WID_CHAR = 0, >> WID_SHORT = 1, >> WID_INT = 2, >> @@ -326,8 +326,7 @@ typedef enum { >> WID_ADR = 7, >> WID_UNDEF = 8, >> WID_TYPE_FORCE_32BIT = 0xFFFFFFFF >> - >> -} WID_TYPE_T, tenuWIDtype; >> +}; >> >> typedef enum { >> WID_NIL = 0xffff, >> -- >> 1.9.1 > -- > Sincerely yours, > Mike. > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/wilc1000/coreconfigurator.h index 306efc9..02faf58 100644 --- a/drivers/staging/wilc1000/coreconfigurator.h +++ b/drivers/staging/wilc1000/coreconfigurator.h @@ -72,7 +72,7 @@ typedef enum { struct wid { u16 u16WIDid; - tenuWIDtype enuWIDtype; + enum WID_TYPE enuWIDtype; s32 s32ValueSize; s8 *ps8WidVal; }; diff --git a/drivers/staging/wilc1000/host_interface.h b/drivers/staging/wilc1000/host_interface.h index 1848f53..2ca6a6e 100644 --- a/drivers/staging/wilc1000/host_interface.h +++ b/drivers/staging/wilc1000/host_interface.h @@ -59,7 +59,7 @@ typedef struct { u16 cfg_wid; - WID_TYPE_T cfg_type; + enum WID_TYPE cfg_type; s8 *pu8Para; } cfg_param_t; diff --git a/drivers/staging/wilc1000/wilc_wlan_if.h b/drivers/staging/wilc1000/wilc_wlan_if.h index 8fec64d..be972af 100644 --- a/drivers/staging/wilc1000/wilc_wlan_if.h +++ b/drivers/staging/wilc1000/wilc_wlan_if.h @@ -315,7 +315,7 @@ typedef enum { SW_TRIGGER_ABORT, } TX_ABORT_OPTION_T; -typedef enum { +enum WID_TYPE { WID_CHAR = 0, WID_SHORT = 1, WID_INT = 2, @@ -326,8 +326,7 @@ typedef enum { WID_ADR = 7, WID_UNDEF = 8, WID_TYPE_FORCE_32BIT = 0xFFFFFFFF - -} WID_TYPE_T, tenuWIDtype; +}; typedef enum { WID_NIL = 0xffff,