| Message ID | 1444436822-6632-3-git-send-email-sagig@mellanox.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Oct 10, 2015 at 3:27 AM, Sagi Grimberg <sagig@mellanox.com> wrote: > iser can handle it and it can dramatically reduce the > number of SG elements. It doesn't make much of a difference at > the moment, Right, b/c we would go and break these SGs to 4k chunks. > but with arbitrary SG list support it will benefit greatly. Y? please put some wording here to clarify. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>> but with arbitrary SG list support it will benefit greatly. > > Y? please put some wording here to clarify. Well, because when a device will accept true SG lists then it would benefit the HCA caching/fetching to have less SG elements. I'll add a sentence to the change log. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c index f559fe9e3baf..8017f3a049fb 100644 --- a/drivers/infiniband/ulp/iser/iscsi_iser.c +++ b/drivers/infiniband/ulp/iser/iscsi_iser.c @@ -990,7 +990,7 @@ static struct scsi_host_template iscsi_iser_sht = { .eh_device_reset_handler= iscsi_eh_device_reset, .eh_target_reset_handler = iscsi_eh_recover_target, .target_alloc = iscsi_target_alloc, - .use_clustering = DISABLE_CLUSTERING, + .use_clustering = ENABLE_CLUSTERING, .slave_alloc = iscsi_iser_slave_alloc, .proc_name = "iscsi_iser", .this_id = -1,
iser can handle it and it can dramatically reduce the number of SG elements. It doesn't make much of a difference at the moment, but with arbitrary SG list support it will benefit greatly. Signed-off-by: Sagi Grimberg <sagig@mellanox.com> --- drivers/infiniband/ulp/iser/iscsi_iser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)