diff mbox

[v1,2/2] IB/iser: Enable SG clustering

Message ID 1444577707-15778-3-git-send-email-sagig@mellanox.com (mailing list archive)
State Superseded
Headers show

Commit Message

Sagi Grimberg Oct. 11, 2015, 3:35 p.m. UTC
iser can handle it and it can dramatically reduce the
number of SG elements. It doesn't make much of a difference at
the moment, but with arbitrary SG list support it will benefit
greatly.

Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
---
 drivers/infiniband/ulp/iser/iscsi_iser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sagi Grimberg Oct. 11, 2015, 3:38 p.m. UTC | #1
On 10/11/2015 6:35 PM, Sagi Grimberg wrote:
> iser can handle it and it can dramatically reduce the
> number of SG elements. It doesn't make much of a difference at
> the moment, but with arbitrary SG list support it will benefit
> greatly.
>

Bahh, I updated the change-log in the previous revision :(

Doug would you mind updating the change-log on the fly to:

iser can handle it and it can dramatically reduce the
number of SG elements. It doesn't make much of a difference at
the moment, but with arbitrary SG list support it will benefit
greatly as it would reduce the size of the HW descriptors array.

Thanks and sorry...

Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Or Gerlitz Oct. 11, 2015, 6:56 p.m. UTC | #2
On Sun, Oct 11, 2015 at 6:38 PM, Sagi Grimberg <sagig@dev.mellanox.co.il> wrote:
> On 10/11/2015 6:35 PM, Sagi Grimberg wrote:
>>
>> iser can handle it and it can dramatically reduce the
>> number of SG elements. It doesn't make much of a difference at
>> the moment, but with arbitrary SG list support it will benefit
>> greatly.
>>
>
> Bahh, I updated the change-log in the previous revision :(
>
> Doug would you mind updating the change-log on the fly to:

Doug,  I sent Sagi a note asking to improve the change-log, lets get
this done prior to picking the patch.

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c
index f559fe9e3baf..8017f3a049fb 100644
--- a/drivers/infiniband/ulp/iser/iscsi_iser.c
+++ b/drivers/infiniband/ulp/iser/iscsi_iser.c
@@ -990,7 +990,7 @@  static struct scsi_host_template iscsi_iser_sht = {
 	.eh_device_reset_handler= iscsi_eh_device_reset,
 	.eh_target_reset_handler = iscsi_eh_recover_target,
 	.target_alloc		= iscsi_target_alloc,
-	.use_clustering         = DISABLE_CLUSTERING,
+	.use_clustering         = ENABLE_CLUSTERING,
 	.slave_alloc            = iscsi_iser_slave_alloc,
 	.proc_name              = "iscsi_iser",
 	.this_id                = -1,