| Message ID | 1444268961-7551-8-git-send-email-tony.cho@atmel.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
I feel like the name 'statistics' is very vague. I guess it's so vague that it's unlikely anyone else will try use it... regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Oct 09, 2015 at 11:16:28AM +0300, Dan Carpenter wrote: > I feel like the name 'statistics' is very vague. I guess it's so vague > that it's unlikely anyone else will try use it... > A lot of these are pretty vague. But I guess it's probably ok... Nevermind me. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Dan, I will find much clearer naming rules when sending version 2 for them. Thanks for your opinion, Tony. On 2015? 10? 09? 17:16, Dan Carpenter wrote: > I feel like the name 'statistics' is very vague. I guess it's so vague > that it's unlikely anyone else will try use it... > > regards, > dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index c370e8d..e6e79c7 100644 --- a/drivers/staging/wilc1000/host_interface.c +++ b/drivers/staging/wilc1000/host_interface.c @@ -2973,7 +2973,7 @@ static void Handle_GetLinkspeed(struct host_if_drv *drvHandler) } -s32 Handle_GetStatistics(struct host_if_drv *drvHandler, tstrStatistics *pstrStatistics) +s32 Handle_GetStatistics(struct host_if_drv *drvHandler, struct statistics *pstrStatistics) { struct wid strWIDList[5]; u32 u32WidsCount = 0, s32Error = 0; @@ -3986,7 +3986,7 @@ static int hostIFthread(void *pvArg) break; case HOST_IF_MSG_GET_STATISTICS: - Handle_GetStatistics(msg.drv, (tstrStatistics *)msg.body.data); + Handle_GetStatistics(msg.drv, (struct statistics *)msg.body.data); break; case HOST_IF_MSG_GET_CHNL: @@ -5533,7 +5533,7 @@ s32 host_int_get_link_speed(struct host_if_drv *hWFIDrv, s8 *ps8lnkspd) return s32Error; } -s32 host_int_get_statistics(struct host_if_drv *hWFIDrv, tstrStatistics *pstrStatistics) +s32 host_int_get_statistics(struct host_if_drv *hWFIDrv, struct statistics *pstrStatistics) { s32 s32Error = 0; struct host_if_msg msg; diff --git a/drivers/staging/wilc1000/host_interface.h b/drivers/staging/wilc1000/host_interface.h index b4cc164..d01bb8e 100644 --- a/drivers/staging/wilc1000/host_interface.h +++ b/drivers/staging/wilc1000/host_interface.h @@ -57,14 +57,13 @@ #define SCAN_EVENT_DONE_ABORTED #define NUM_CONCURRENT_IFC 2 -typedef struct _tstrStatistics { +struct statistics { u8 u8LinkSpeed; s8 s8RSSI; u32 u32TxCount; u32 u32RxCount; u32 u32TxFailureCount; - -} tstrStatistics; +}; enum host_if_state { HOST_IF_IDLE = 0, @@ -1176,6 +1175,6 @@ static s32 Handle_ScanDone(struct host_if_drv *drvHandler, tenuScanEvent enuEven void host_int_freeJoinParams(void *pJoinParams); -s32 host_int_get_statistics(struct host_if_drv *hWFIDrv, tstrStatistics *pstrStatistics); +s32 host_int_get_statistics(struct host_if_drv *hWFIDrv, struct statistics *pstrStatistics); #endif diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c index 42219ea..d5b0214 100644 --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c @@ -1576,7 +1576,7 @@ static int get_station(struct wiphy *wiphy, struct net_device *dev, } if (nic->iftype == STATION_MODE) { - tstrStatistics strStatistics; + struct statistics strStatistics; host_int_get_statistics(priv->hWILCWFIDrv, &strStatistics);