| Message ID | 1448196517-13341-1-git-send-email-saurabh.truth@gmail.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
On Sun, Nov 22, 2015 at 06:18:37PM +0530, Saurabh Sengar wrote:
> removing null dereference
How so? These are just sparse annotations, so I can't see how we'll
actually derference them. That beeing said they certainly are
incorrect..
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index 307bdbc..613a853 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -1064,13 +1064,10 @@ static void mlx5_ib_lock_cqs(struct mlx5_ib_cq *send_cq, struct mlx5_ib_cq *recv } } else { spin_lock_irq(&send_cq->lock); - __acquire(&recv_cq->lock); } } else if (recv_cq) { spin_lock_irq(&recv_cq->lock); - __acquire(&send_cq->lock); } else { - __acquire(&send_cq->lock); __acquire(&recv_cq->lock); } } @@ -1091,15 +1088,12 @@ static void mlx5_ib_unlock_cqs(struct mlx5_ib_cq *send_cq, struct mlx5_ib_cq *re spin_unlock_irq(&recv_cq->lock); } } else { - __release(&recv_cq->lock); spin_unlock_irq(&send_cq->lock); } } else if (recv_cq) { - __release(&send_cq->lock); spin_unlock_irq(&recv_cq->lock); } else { __release(&recv_cq->lock); - __release(&send_cq->lock); } }
removing null dereference Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com> --- is there any better way to fix it ? as if there is no 'x' there is no way we can access 'x->lock' drivers/infiniband/hw/mlx5/qp.c | 6 ------ 1 file changed, 6 deletions(-)