diff mbox

[15/15] i40iw: changes for build of i40iw module

Message ID 1450295919-17292-16-git-send-email-faisal.latif@intel.com (mailing list archive)
State Superseded
Headers show

Commit Message

Faisal Latif Dec. 16, 2015, 7:58 p.m. UTC 
IAINTAINERS< Kconfig, Makefile and rdma_netlink.h to include
i40iw

Signed-off-by: Faisal Latif <faisal.latif@intel.com>
---
 MAINTAINERS                      | 10 ++++++++++
 drivers/infiniband/Kconfig       |  1 +
 drivers/infiniband/hw/Makefile   |  1 +
 include/uapi/rdma/rdma_netlink.h |  1 +
 4 files changed, 13 insertions(+)

Comments

kernel test robot Dec. 16, 2015, 8:34 p.m. UTC | #1 
Hi Faisal,

[auto build test WARNING on net/master]
[also build test WARNING on v4.4-rc5 next-20151216]
[cannot apply to net-next/master]

url:    https://github.com/0day-ci/linux/commits/Faisal-Latif/add-Intel-R-X722-iWARP-driver/20151217-040340
config: arm-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   In file included from include/linux/byteorder/big_endian.h:4:0,
                    from arch/arm/include/uapi/asm/byteorder.h:19,
                    from include/asm-generic/bitops/le.h:5,
                    from arch/arm/include/asm/bitops.h:340,
                    from include/linux/bitops.h:36,
                    from include/linux/kernel.h:10,
                    from include/linux/skbuff.h:17,
                    from include/linux/ip.h:20,
                    from drivers/infiniband/hw/i40iw/i40iw_cm.c:36:
   drivers/infiniband/hw/i40iw/i40iw_cm.c: In function 'i40iw_init_tcp_ctx':
   include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer implicitly truncated to unsigned type [-Woverflow]
    #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))
                             ^
   include/linux/byteorder/generic.h:87:21: note: in expansion of macro '__cpu_to_le32'
    #define cpu_to_le32 __cpu_to_le32
                        ^
>> drivers/infiniband/hw/i40iw/i40iw_cm.c:3513:18: note: in expansion of macro 'cpu_to_le32'
     tcp_info->ttl = cpu_to_le32(I40IW_DEFAULT_TTL);
                     ^

vim +/cpu_to_le32 +3513 drivers/infiniband/hw/i40iw/i40iw_cm.c

2d207efd Faisal Latif 2015-12-16  3497   * i40iw_init_tcp_ctx - setup qp context
2d207efd Faisal Latif 2015-12-16  3498   * @cm_node: connection's node
2d207efd Faisal Latif 2015-12-16  3499   * @tcp_info: offload info for tcp
2d207efd Faisal Latif 2015-12-16  3500   * @iwqp: associate qp for the connection
2d207efd Faisal Latif 2015-12-16  3501   */
2d207efd Faisal Latif 2015-12-16  3502  static void i40iw_init_tcp_ctx(struct i40iw_cm_node *cm_node,
2d207efd Faisal Latif 2015-12-16  3503  			       struct i40iw_tcp_offload_info *tcp_info,
2d207efd Faisal Latif 2015-12-16  3504  			       struct i40iw_qp *iwqp)
2d207efd Faisal Latif 2015-12-16  3505  {
2d207efd Faisal Latif 2015-12-16  3506  	tcp_info->ipv4 = cm_node->ipv4;
2d207efd Faisal Latif 2015-12-16  3507  	tcp_info->drop_ooo_seg = true;
2d207efd Faisal Latif 2015-12-16  3508  	tcp_info->wscale = true;
2d207efd Faisal Latif 2015-12-16  3509  	tcp_info->ignore_tcp_opt = true;
2d207efd Faisal Latif 2015-12-16  3510  	tcp_info->ignore_tcp_uns_opt = true;
2d207efd Faisal Latif 2015-12-16  3511  	tcp_info->no_nagle = false;
2d207efd Faisal Latif 2015-12-16  3512  
2d207efd Faisal Latif 2015-12-16 @3513  	tcp_info->ttl = cpu_to_le32(I40IW_DEFAULT_TTL);
2d207efd Faisal Latif 2015-12-16  3514  	tcp_info->rtt_var = cpu_to_le32(I40IW_DEFAULT_RTT_VAR);
2d207efd Faisal Latif 2015-12-16  3515  	tcp_info->ss_thresh = cpu_to_le32(I40IW_DEFAULT_SS_THRESH);
2d207efd Faisal Latif 2015-12-16  3516  	tcp_info->rexmit_thresh = I40IW_DEFAULT_REXMIT_THRESH;
2d207efd Faisal Latif 2015-12-16  3517  
2d207efd Faisal Latif 2015-12-16  3518  	tcp_info->tcp_state = I40IW_TCP_STATE_ESTABLISHED;
2d207efd Faisal Latif 2015-12-16  3519  	tcp_info->snd_wscale = cm_node->tcp_cntxt.snd_wscale;
2d207efd Faisal Latif 2015-12-16  3520  	tcp_info->rcv_wscale = cm_node->tcp_cntxt.rcv_wscale;
2d207efd Faisal Latif 2015-12-16  3521  

:::::: The code at line 3513 was first introduced by commit
:::::: 2d207efd7fd9e5a190b2ebd6f077139412b0343f i40iw: add connection management code

:::::: TO: Faisal Latif <faisal.latif@intel.com>
:::::: CC: 0day robot <fengguang.wu@intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
Christoph Hellwig Dec. 16, 2015, 8:53 p.m. UTC | #2 
> --- a/include/uapi/rdma/rdma_netlink.h
> +++ b/include/uapi/rdma/rdma_netlink.h
> @@ -5,6 +5,7 @@
>  
>  enum {
>  	RDMA_NL_RDMA_CM = 1,
> +	RDMA_NL_I40IW,
>  	RDMA_NL_NES,
>  	RDMA_NL_C4IW,
>  	RDMA_NL_LS,	/* RDMA Local Services */

This changes the values for the existing RDMA_NL_NES, RDMA_NL_C4IW and
RDMA_NL_LS symbols.  Please add your new value at the end.  And it
should probably be a separate patch as it's not related to the build
system and referenced by the earlier patches.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
kernel test robot Dec. 17, 2015, 5:14 a.m. UTC | #3 
Hi Faisal,

[auto build test WARNING on net/master]
[also build test WARNING on v4.4-rc5 next-20151216]
[cannot apply to net-next/master]

url:    https://github.com/0day-ci/linux/commits/Faisal-Latif/add-Intel-R-X722-iWARP-driver/20151217-040340
config: sparc-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sparc 

All warnings (new ones prefixed by >>):

   drivers/infiniband/hw/i40iw/i40iw_verbs.c: In function 'i40iw_setup_kmode_qp':
>> drivers/infiniband/hw/i40iw/i40iw_verbs.c:571:28: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
     info->rq_pa = (uintptr_t)((u8 *)mem->pa + (sqdepth * I40IW_QP_WQE_MIN_SIZE));
                               ^

vim +571 drivers/infiniband/hw/i40iw/i40iw_verbs.c

e4d636f5 Faisal Latif 2015-12-16  555  	ukinfo->rq_wrid_array = (u64 *)&ukinfo->sq_wrtrk_array[sqdepth];
e4d636f5 Faisal Latif 2015-12-16  556  
e4d636f5 Faisal Latif 2015-12-16  557  	size = (sqdepth + rqdepth) * I40IW_QP_WQE_MIN_SIZE;
e4d636f5 Faisal Latif 2015-12-16  558  	size += (I40IW_SHADOW_AREA_SIZE << 3);
e4d636f5 Faisal Latif 2015-12-16  559  
e4d636f5 Faisal Latif 2015-12-16  560  	status = i40iw_allocate_dma_mem(iwdev->sc_dev.hw, mem, size, 256);
e4d636f5 Faisal Latif 2015-12-16  561  	if (status) {
e4d636f5 Faisal Latif 2015-12-16  562  		kfree(ukinfo->sq_wrtrk_array);
e4d636f5 Faisal Latif 2015-12-16  563  		ukinfo->sq_wrtrk_array = NULL;
e4d636f5 Faisal Latif 2015-12-16  564  		return -ENOMEM;
e4d636f5 Faisal Latif 2015-12-16  565  	}
e4d636f5 Faisal Latif 2015-12-16  566  
e4d636f5 Faisal Latif 2015-12-16  567  	ukinfo->sq = mem->va;
e4d636f5 Faisal Latif 2015-12-16  568  	info->sq_pa = mem->pa;
e4d636f5 Faisal Latif 2015-12-16  569  
e4d636f5 Faisal Latif 2015-12-16  570  	ukinfo->rq = (u64 *)((u8 *)mem->va + (sqdepth * I40IW_QP_WQE_MIN_SIZE));
e4d636f5 Faisal Latif 2015-12-16 @571  	info->rq_pa = (uintptr_t)((u8 *)mem->pa + (sqdepth * I40IW_QP_WQE_MIN_SIZE));
e4d636f5 Faisal Latif 2015-12-16  572  
e4d636f5 Faisal Latif 2015-12-16  573  	ukinfo->shadow_area = (u64 *)((u8 *)ukinfo->rq +
e4d636f5 Faisal Latif 2015-12-16  574  				      (rqdepth * I40IW_QP_WQE_MIN_SIZE));
e4d636f5 Faisal Latif 2015-12-16  575  	info->shadow_area_pa = info->rq_pa + (rqdepth * I40IW_QP_WQE_MIN_SIZE);
e4d636f5 Faisal Latif 2015-12-16  576  
e4d636f5 Faisal Latif 2015-12-16  577  	ukinfo->sq_size = sq_size;
e4d636f5 Faisal Latif 2015-12-16  578  	ukinfo->rq_size = rq_size;
e4d636f5 Faisal Latif 2015-12-16  579  	ukinfo->qp_id = iwqp->ibqp.qp_num;

:::::: The code at line 571 was first introduced by commit
:::::: e4d636f5c9dea5d2dd1f5c74e3a2235218a537a8 i40iw: add files for iwarp interface

:::::: TO: Faisal Latif <faisal.latif@intel.com>
:::::: CC: 0day robot <fengguang.wu@intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 69c8a9c..fc0ee30 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5600,6 +5600,16 @@  F:	Documentation/networking/i40evf.txt
 F:	drivers/net/ethernet/intel/
 F:	drivers/net/ethernet/intel/*/
 
+INTEL RDMA RNIC DRIVER
+M:	Faisal Latif <faisal.latif@intel.com>
+R:	Chien Tin Tung <chien.tin.tung@intel.com>
+R:	Mustafa Ismail <mustafa.ismail@intel.com>
+R:	Shiraz Saleem <shiraz.saleem@intel.com>
+R:	Tatyana Nikolova <tatyana.e.nikolova@intel.com>
+L:	linux-rdma@vger.kernel.org
+S:	Supported
+F:	drivers/infiniband/hw/i40iw/
+
 INTEL-MID GPIO DRIVER
 M:	David Cohen <david.a.cohen@linux.intel.com>
 L:	linux-gpio@vger.kernel.org
diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
index aa26f3c..7ddd81f 100644
--- a/drivers/infiniband/Kconfig
+++ b/drivers/infiniband/Kconfig
@@ -58,6 +58,7 @@  source "drivers/infiniband/hw/mthca/Kconfig"
 source "drivers/infiniband/hw/qib/Kconfig"
 source "drivers/infiniband/hw/cxgb3/Kconfig"
 source "drivers/infiniband/hw/cxgb4/Kconfig"
+source "drivers/infiniband/hw/i40iw/Kconfig"
 source "drivers/infiniband/hw/mlx4/Kconfig"
 source "drivers/infiniband/hw/mlx5/Kconfig"
 source "drivers/infiniband/hw/nes/Kconfig"
diff --git a/drivers/infiniband/hw/Makefile b/drivers/infiniband/hw/Makefile
index aded2a5..c7ad0a4 100644
--- a/drivers/infiniband/hw/Makefile
+++ b/drivers/infiniband/hw/Makefile
@@ -2,6 +2,7 @@  obj-$(CONFIG_INFINIBAND_MTHCA)		+= mthca/
 obj-$(CONFIG_INFINIBAND_QIB)		+= qib/
 obj-$(CONFIG_INFINIBAND_CXGB3)		+= cxgb3/
 obj-$(CONFIG_INFINIBAND_CXGB4)		+= cxgb4/
+obj-$(CONFIG_INFINIBAND_I40IW)		+= i40iw/
 obj-$(CONFIG_MLX4_INFINIBAND)		+= mlx4/
 obj-$(CONFIG_MLX5_INFINIBAND)		+= mlx5/
 obj-$(CONFIG_INFINIBAND_NES)		+= nes/
diff --git a/include/uapi/rdma/rdma_netlink.h b/include/uapi/rdma/rdma_netlink.h
index c19a5dc..56bafbe 100644
--- a/include/uapi/rdma/rdma_netlink.h
+++ b/include/uapi/rdma/rdma_netlink.h
@@ -5,6 +5,7 @@ 
 
 enum {
 	RDMA_NL_RDMA_CM = 1,
+	RDMA_NL_I40IW,
 	RDMA_NL_NES,
 	RDMA_NL_C4IW,
 	RDMA_NL_LS,	/* RDMA Local Services */