| Message ID | 896b7d080610c5417a2f09a3bf9d0e20636fcc52.1451211133.git.geliangtang@163.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
Geliang Tang <geliangtang@163.com> writes: > Use to_pci_dev() instead of open-coding it. > > Signed-off-by: Geliang Tang <geliangtang@163.com> The title is wrong, it should be just "ipw2x00: use to_pci_dev()". And please state clearly to what tree you are planning to submit these. I only saw this patch 5, not rest of the patches, so I have no clue what's going to happen with this patchset. Please resend.
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2100.c b/drivers/net/wireless/intel/ipw2x00/ipw2100.c index 36818c7..121294f 100644 --- a/drivers/net/wireless/intel/ipw2x00/ipw2100.c +++ b/drivers/net/wireless/intel/ipw2x00/ipw2100.c @@ -3514,7 +3514,7 @@ static void ipw2100_msg_free(struct ipw2100_priv *priv) static ssize_t show_pci(struct device *d, struct device_attribute *attr, char *buf) { - struct pci_dev *pci_dev = container_of(d, struct pci_dev, dev); + struct pci_dev *pci_dev = to_pci_dev(d); char *out = buf; int i, j; u32 val;
Use to_pci_dev() instead of open-coding it. Signed-off-by: Geliang Tang <geliangtang@163.com> --- drivers/net/wireless/intel/ipw2x00/ipw2100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)