| Message ID | 1454344071-15881-5-git-send-email-tvrtko.ursulin@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 01 Feb 2016, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > --- > drivers/gpu/drm/i915/Kconfig | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig > index 051eab33e4c7..7636bf918d97 100644 > --- a/drivers/gpu/drm/i915/Kconfig > +++ b/drivers/gpu/drm/i915/Kconfig > @@ -47,3 +47,15 @@ config DRM_I915_PRELIMINARY_HW_SUPPORT > option changes the default for that module option. > > If in doubt, say "N". > + > +config DRM_I915_DEBUG > + bool "Enable additional driver debugging" > + depends on DRM_I915 > + default n > + help > + Choose this option to turn on extra driver debugging that may affect > + performance but will catch some internal issues. > + > + Recommended for driver developers only. > + > + If in doubt, say "N". I kind of liked Chris' approach of adding a submenu http://patchwork.freedesktop.org/patch/msgid/1451902412-25459-1-git-send-email-chris@chris-wilson.co.uk BR, Jani.
On 02/02/16 09:18, Jani Nikula wrote: > On Mon, 01 Feb 2016, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote: >> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >> >> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >> --- >> drivers/gpu/drm/i915/Kconfig | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig >> index 051eab33e4c7..7636bf918d97 100644 >> --- a/drivers/gpu/drm/i915/Kconfig >> +++ b/drivers/gpu/drm/i915/Kconfig >> @@ -47,3 +47,15 @@ config DRM_I915_PRELIMINARY_HW_SUPPORT >> option changes the default for that module option. >> >> If in doubt, say "N". >> + >> +config DRM_I915_DEBUG >> + bool "Enable additional driver debugging" >> + depends on DRM_I915 >> + default n >> + help >> + Choose this option to turn on extra driver debugging that may affect >> + performance but will catch some internal issues. >> + >> + Recommended for driver developers only. >> + >> + If in doubt, say "N". > > I kind of liked Chris' approach of adding a submenu > http://patchwork.freedesktop.org/patch/msgid/1451902412-25459-1-git-send-email-chris@chris-wilson.co.uk I don't mind either way - what was decided for that patch - is it going in? Regards, Tvrtko
On Tue, 02 Feb 2016, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote: > On 02/02/16 09:18, Jani Nikula wrote: >> On Mon, 01 Feb 2016, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote: >>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >>> >>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >>> --- >>> drivers/gpu/drm/i915/Kconfig | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig >>> index 051eab33e4c7..7636bf918d97 100644 >>> --- a/drivers/gpu/drm/i915/Kconfig >>> +++ b/drivers/gpu/drm/i915/Kconfig >>> @@ -47,3 +47,15 @@ config DRM_I915_PRELIMINARY_HW_SUPPORT >>> option changes the default for that module option. >>> >>> If in doubt, say "N". >>> + >>> +config DRM_I915_DEBUG >>> + bool "Enable additional driver debugging" >>> + depends on DRM_I915 >>> + default n >>> + help >>> + Choose this option to turn on extra driver debugging that may affect >>> + performance but will catch some internal issues. >>> + >>> + Recommended for driver developers only. >>> + >>> + If in doubt, say "N". >> >> I kind of liked Chris' approach of adding a submenu >> http://patchwork.freedesktop.org/patch/msgid/1451902412-25459-1-git-send-email-chris@chris-wilson.co.uk > > I don't mind either way - what was decided for that patch - is it > going in? I think we'd like to have it, but last time it blew up on randconfig. Chris, do we avoid that now? Tvrtko, in any case, you could pick up the submenu part from there. BR, Jani. > > Regards, > > Tvrtko >
On 02/02/16 09:40, Jani Nikula wrote: > On Tue, 02 Feb 2016, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote: >> On 02/02/16 09:18, Jani Nikula wrote: >>> On Mon, 01 Feb 2016, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote: >>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >>>> >>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >>>> --- >>>> drivers/gpu/drm/i915/Kconfig | 12 ++++++++++++ >>>> 1 file changed, 12 insertions(+) >>>> >>>> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig >>>> index 051eab33e4c7..7636bf918d97 100644 >>>> --- a/drivers/gpu/drm/i915/Kconfig >>>> +++ b/drivers/gpu/drm/i915/Kconfig >>>> @@ -47,3 +47,15 @@ config DRM_I915_PRELIMINARY_HW_SUPPORT >>>> option changes the default for that module option. >>>> >>>> If in doubt, say "N". >>>> + >>>> +config DRM_I915_DEBUG >>>> + bool "Enable additional driver debugging" >>>> + depends on DRM_I915 >>>> + default n >>>> + help >>>> + Choose this option to turn on extra driver debugging that may affect >>>> + performance but will catch some internal issues. >>>> + >>>> + Recommended for driver developers only. >>>> + >>>> + If in doubt, say "N". >>> >>> I kind of liked Chris' approach of adding a submenu >>> http://patchwork.freedesktop.org/patch/msgid/1451902412-25459-1-git-send-email-chris@chris-wilson.co.uk >> >> I don't mind either way - what was decided for that patch - is it >> going in? > > I think we'd like to have it, but last time it blew up on > randconfig. Chris, do we avoid that now? > > Tvrtko, in any case, you could pick up the submenu part from there. I have - and also respun the enlarged series of misc fixes and debugging infrastructure. Reviewers welcome. :) Regards, Tvrtko
diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index 051eab33e4c7..7636bf918d97 100644 --- a/drivers/gpu/drm/i915/Kconfig +++ b/drivers/gpu/drm/i915/Kconfig @@ -47,3 +47,15 @@ config DRM_I915_PRELIMINARY_HW_SUPPORT option changes the default for that module option. If in doubt, say "N". + +config DRM_I915_DEBUG + bool "Enable additional driver debugging" + depends on DRM_I915 + default n + help + Choose this option to turn on extra driver debugging that may affect + performance but will catch some internal issues. + + Recommended for driver developers only. + + If in doubt, say "N".