| Message ID | 56ABF1AF.3070301@sandisk.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
> + .node_acl_size = sizeof(struct se_node_acl), This is the default, no need to even set this member. Otherwise looks fine: Reviewed-by: Christoph Hellwig <hch@lst.de> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Looks good. Reviewed-by: Alex Estrin <alex.estrin@intel.com> > Since struct srpt_node_acl is identical to struct se_node_acl, > remove the definition of the former structure. This patch does > not change any functionality. > > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Sagi Grimberg <sagig@mellanox.com> > --- > drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +- > drivers/infiniband/ulp/srpt/ib_srpt.h | 8 -------- > 2 files changed, 1 insertion(+), 9 deletions(-) > > diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c > b/drivers/infiniband/ulp/srpt/ib_srpt.c > index f65ae60..fde32ed 100644 > --- a/drivers/infiniband/ulp/srpt/ib_srpt.c > +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c > @@ -3565,7 +3565,7 @@ static struct configfs_attribute *srpt_wwn_attrs[] = { > static const struct target_core_fabric_ops srpt_template = { > .module = THIS_MODULE, > .name = "srpt", > - .node_acl_size = sizeof(struct srpt_node_acl), > + .node_acl_size = sizeof(struct se_node_acl), > .get_fabric_name = srpt_get_fabric_name, > .tpg_get_wwn = srpt_get_fabric_wwn, > .tpg_get_tag = srpt_get_tag, > diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.h > b/drivers/infiniband/ulp/srpt/ib_srpt.h > index 09037f2..b0ede97 100644 > --- a/drivers/infiniband/ulp/srpt/ib_srpt.h > +++ b/drivers/infiniband/ulp/srpt/ib_srpt.h > @@ -363,12 +363,4 @@ struct srpt_device { > struct list_head list; > }; > > -/** > - * struct srpt_node_acl - Per-initiator ACL data (managed via configfs). > - * @nacl: Target core node ACL information. > - */ > -struct srpt_node_acl { > - struct se_node_acl nacl; > -}; > - > #endif /* IB_SRPT_H */ > -- > 2.7.0
diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c index f65ae60..fde32ed 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.c +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c @@ -3565,7 +3565,7 @@ static struct configfs_attribute *srpt_wwn_attrs[] = { static const struct target_core_fabric_ops srpt_template = { .module = THIS_MODULE, .name = "srpt", - .node_acl_size = sizeof(struct srpt_node_acl), + .node_acl_size = sizeof(struct se_node_acl), .get_fabric_name = srpt_get_fabric_name, .tpg_get_wwn = srpt_get_fabric_wwn, .tpg_get_tag = srpt_get_tag, diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.h b/drivers/infiniband/ulp/srpt/ib_srpt.h index 09037f2..b0ede97 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.h +++ b/drivers/infiniband/ulp/srpt/ib_srpt.h @@ -363,12 +363,4 @@ struct srpt_device { struct list_head list; }; -/** - * struct srpt_node_acl - Per-initiator ACL data (managed via configfs). - * @nacl: Target core node ACL information. - */ -struct srpt_node_acl { - struct se_node_acl nacl; -}; - #endif /* IB_SRPT_H */
Since struct srpt_node_acl is identical to struct se_node_acl, remove the definition of the former structure. This patch does not change any functionality. Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Sagi Grimberg <sagig@mellanox.com> --- drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +- drivers/infiniband/ulp/srpt/ib_srpt.h | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-)