| Message ID | 56E6A713.1030604@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2016/3/14 19:57, piaojun wrote: > In dlm_send_join_cancels(), unsigned int node is assigned -1, this will > lead variable overflow. Although this won't cause any runtime problem, > the code looks a little uncoordinated. > > Signed-off-by: Jun Piao <piaojun@huawei.com> > Reviewed-by: Joseph Qi <joseph.qi@huawei.com> > --- > dlm/dlmdomain.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/dlm/dlmdomain.c b/dlm/dlmdomain.c > index 2ee7fe7..61bafa7 100644 > --- a/dlm/dlmdomain.c > +++ b/dlm/dlmdomain.c > @@ -1395,8 +1395,7 @@ static int dlm_send_join_cancels(struct dlm_ctxt *dlm, > unsigned long *node_map, > unsigned int map_size) > { > - int status, tmpstat; > - unsigned int node; > + int status, tmpstat, int node; This is not right. NAK. > > if (map_size != (BITS_TO_LONGS(O2NM_MAX_NODES) * > sizeof(unsigned long))) { >
On 2016/3/14 20:21, Joseph Qi wrote: > On 2016/3/14 19:57, piaojun wrote: >> In dlm_send_join_cancels(), unsigned int node is assigned -1, this will >> lead variable overflow. Although this won't cause any runtime problem, >> the code looks a little uncoordinated. >> >> Signed-off-by: Jun Piao <piaojun@huawei.com> >> Reviewed-by: Joseph Qi <joseph.qi@huawei.com> >> --- >> dlm/dlmdomain.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/dlm/dlmdomain.c b/dlm/dlmdomain.c >> index 2ee7fe7..61bafa7 100644 >> --- a/dlm/dlmdomain.c >> +++ b/dlm/dlmdomain.c >> @@ -1395,8 +1395,7 @@ static int dlm_send_join_cancels(struct dlm_ctxt *dlm, >> unsigned long *node_map, >> unsigned int map_size) >> { >> - int status, tmpstat; >> - unsigned int node; >> + int status, tmpstat, int node; > This is not right. NAK. > Hi Joseph Qi, Thanks for your prompt, I have sent a V2 patch to fix this. >> >> if (map_size != (BITS_TO_LONGS(O2NM_MAX_NODES) * >> sizeof(unsigned long))) { >> > > > > . >
diff --git a/dlm/dlmdomain.c b/dlm/dlmdomain.c index 2ee7fe7..61bafa7 100644 --- a/dlm/dlmdomain.c +++ b/dlm/dlmdomain.c @@ -1395,8 +1395,7 @@ static int dlm_send_join_cancels(struct dlm_ctxt *dlm, unsigned long *node_map, unsigned int map_size) { - int status, tmpstat; - unsigned int node; + int status, tmpstat, int node; if (map_size != (BITS_TO_LONGS(O2NM_MAX_NODES) * sizeof(unsigned long))) {