| Message ID | BANLkTimrSD-zB5q+oM=8HkZ1nsTUNEG81g@mail.gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Thu, May 26, 2011 at 10:30 AM, Adrian Chadd <adrian@freebsd.org> wrote: > Hi, > > The AR9287 initial calibration in ar9002_hw_init_cal() isn't ever > called because the Kite check (AR_SREV_9285_12_OR_LATER()) matches on > MACs versioned Kite and later. Adrian this change looks logically correct. but as there were lot of regwrites in the original path, I am not sure how this change will effect the throughput especially in noisy environment conditions/stress testing. > > The Atheros newma code checks it is Kite as well as being Kite >= 1.2. > > I don't currently have Linux ath9k on something with an AR9287 so I'd > appreciate it if this were verified by someone who has. > > The patch is quite simple: > > diff --git a/drivers/net/wireless/ath/ath9k/ar9002_calib.c > b/drivers/net/wireless/ath/ath9k/ar9002_calib.c > index 015d974..2d4c091 100644 > --- a/drivers/net/wireless/ath/ath9k/ar9002_calib.c > +++ b/drivers/net/wireless/ath/ath9k/ar9002_calib.c > @@ -829,7 +829,7 @@ static bool ar9002_hw_init_cal(struct ath_hw *ah, > struct ath9k_channel *chan) > if (AR_SREV_9271(ah)) { > if (!ar9285_hw_cl_cal(ah, chan)) > return false; > - } else if (AR_SREV_9285_12_OR_LATER(ah)) { > + } else if (AR_SREV_9285(ah) && AR_SREV_9285_12_OR_LATER(ah)) { > if (!ar9285_hw_clc(ah, chan)) > return false; > } else { > > Thanks, > > > Adrian > _______________________________________________ > ath9k-devel mailing list > ath9k-devel@lists.ath9k.org > https://lists.ath9k.org/mailman/listinfo/ath9k-devel > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, May 26, 2011 at 10:30 AM, Adrian Chadd <adrian@freebsd.org> wrote: > Hi, > > The AR9287 initial calibration in ar9002_hw_init_cal() isn't ever > called because the Kite check (AR_SREV_9285_12_OR_LATER()) matches on > MACs versioned Kite and later. yes, instead the calibration initialization for AR9285_12_OR_LATER is called. > > The Atheros newma code checks it is Kite as well as being Kite >= 1.2. yes thats true. > > I don't currently have Linux ath9k on something with an AR9287 so I'd > appreciate it if this were verified by someone who has. did a quick preliminary tx throughput test not much difference. > > The patch is quite simple: > > diff --git a/drivers/net/wireless/ath/ath9k/ar9002_calib.c > b/drivers/net/wireless/ath/ath9k/ar9002_calib.c > index 015d974..2d4c091 100644 > --- a/drivers/net/wireless/ath/ath9k/ar9002_calib.c > +++ b/drivers/net/wireless/ath/ath9k/ar9002_calib.c > @@ -829,7 +829,7 @@ static bool ar9002_hw_init_cal(struct ath_hw *ah, > struct ath9k_channel *chan) > if (AR_SREV_9271(ah)) { > if (!ar9285_hw_cl_cal(ah, chan)) > return false; > - } else if (AR_SREV_9285_12_OR_LATER(ah)) { > + } else if (AR_SREV_9285(ah) && AR_SREV_9285_12_OR_LATER(ah)) { > if (!ar9285_hw_clc(ah, chan)) > return false; > } else { > > Thanks, > > > Adrian > _______________________________________________ > ath9k-devel mailing list > ath9k-devel@lists.ath9k.org > https://lists.ath9k.org/mailman/listinfo/ath9k-devel > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 26 May 2011 20:26, Mohammed Shafi <shafi.ath9k@gmail.com> wrote: > > did a quick preliminary tx throughput test not much difference. What about RX sensitivity/errors? Adrian -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, May 26, 2011 at 6:29 PM, Adrian Chadd <adrian@freebsd.org> wrote: > On 26 May 2011 20:26, Mohammed Shafi <shafi.ath9k@gmail.com> wrote: > >> >> did a quick preliminary tx throughput test not much difference. > > What about RX sensitivity/errors? should I look recv debug stats? > > > > Adrian > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 26 May 2011 21:15, Mohammed Shafi <shafi.ath9k@gmail.com> wrote: >> What about RX sensitivity/errors? > > should I look recv debug stats? I'm not a chip developer, so I don't really know. :) I hazard a guess that the rx calibration will affect RX sensitivity, maybe CRC errors? Or maximum link distance? Adrian -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, May 26, 2011 at 7:41 PM, Adrian Chadd <adrian@freebsd.org> wrote: > On 26 May 2011 21:15, Mohammed Shafi <shafi.ath9k@gmail.com> wrote: > >>> What about RX sensitivity/errors? >> >> should I look recv debug stats? > > I'm not a chip developer, so I don't really know. :) > > I hazard a guess that the rx calibration will affect RX sensitivity, > maybe CRC errors? Or maximum link distance? Hmmm ok, if you got a chip please test it. I will be very happy if this patch improves some performance or reduces some CRC errors :) I will also look into this > > > Adrian > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 26 May 2011 22:48, Mohammed Shafi <shafi.ath9k@gmail.com> wrote: >> I hazard a guess that the rx calibration will affect RX sensitivity, >> maybe CRC errors? Or maximum link distance? > > Hmmm ok, if you got a chip please test it. I will be very happy if > this patch improves some performance or reduces some CRC errors :) I > will also look into this Well I've just brought up AR9287 support on FreeBSD with this RX calibration change and initial tests are promising. I unfortunately don't have anything yet w/ mini-PCIe that dual-boots Linux so I can't easily test ath9k out. Hence why I was asking for someone to please investigate for me :) Thanks, Adrian -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, May 26, 2011 at 8:26 PM, Adrian Chadd <adrian@freebsd.org> wrote: > On 26 May 2011 22:48, Mohammed Shafi <shafi.ath9k@gmail.com> wrote: > >>> I hazard a guess that the rx calibration will affect RX sensitivity, >>> maybe CRC errors? Or maximum link distance? >> >> Hmmm ok, if you got a chip please test it. I will be very happy if >> this patch improves some performance or reduces some CRC errors :) I >> will also look into this > > Well I've just brought up AR9287 support on FreeBSD with this RX > calibration change and initial tests are promising. > > I unfortunately don't have anything yet w/ mini-PCIe that dual-boots > Linux so I can't easily test ath9k out. > > Hence why I was asking for someone to please investigate for me :) no problem, sure > > Thanks, > > Adrian > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/ath/ath9k/ar9002_calib.c b/drivers/net/wireless/ath/ath9k/ar9002_calib.c index 015d974..2d4c091 100644 --- a/drivers/net/wireless/ath/ath9k/ar9002_calib.c +++ b/drivers/net/wireless/ath/ath9k/ar9002_calib.c @@ -829,7 +829,7 @@ static bool ar9002_hw_init_cal(struct ath_hw *ah, struct ath9k_channel *chan) if (AR_SREV_9271(ah)) { if (!ar9285_hw_cl_cal(ah, chan)) return false; - } else if (AR_SREV_9285_12_OR_LATER(ah)) { + } else if (AR_SREV_9285(ah) && AR_SREV_9285_12_OR_LATER(ah)) { if (!ar9285_hw_clc(ah, chan)) return false;
Hi, The AR9287 initial calibration in ar9002_hw_init_cal() isn't ever called because the Kite check (AR_SREV_9285_12_OR_LATER()) matches on MACs versioned Kite and later. The Atheros newma code checks it is Kite as well as being Kite >= 1.2. I don't currently have Linux ath9k on something with an AR9287 so I'd appreciate it if this were verified by someone who has. The patch is quite simple: } else { Thanks, Adrian -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html