| Message ID | 1458973495-17403-1-git-send-email-bhumirks@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
Hi All, On Sat, Mar 26, 2016 at 5:24 PM, Bhumika Goyal <bhumirks@gmail.com> wrote: > The functions rtw_enqueue_recvbuf23a and rtw_enqueue_recvbuf23a_to_head > are never used anywhere in the kernel. So, remove their definition and > prototype. > Grepped to find occurences. > > Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Looks right to me. Reviewed-by: Julian Calaby <julian.calaby@gmail.com> > --- > drivers/staging/rtl8723au/core/rtw_recv.c | 25 ------------------------- > drivers/staging/rtl8723au/include/rtw_recv.h | 2 -- > 2 files changed, 27 deletions(-) > > diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c b/drivers/staging/rtl8723au/core/rtw_recv.c > index 989ed07..150dabc 100644 > --- a/drivers/staging/rtl8723au/core/rtw_recv.c > +++ b/drivers/staging/rtl8723au/core/rtw_recv.c > @@ -211,31 +211,6 @@ u32 rtw_free_uc_swdec_pending_queue23a(struct rtw_adapter *adapter) > return cnt; > } > > -int rtw_enqueue_recvbuf23a_to_head(struct recv_buf *precvbuf, struct rtw_queue *queue) > -{ > - spin_lock_bh(&queue->lock); > - > - list_del_init(&precvbuf->list); > - list_add(&precvbuf->list, get_list_head(queue)); > - > - spin_unlock_bh(&queue->lock); > - > - return _SUCCESS; > -} > - > -int rtw_enqueue_recvbuf23a(struct recv_buf *precvbuf, struct rtw_queue *queue) > -{ > - unsigned long irqL; > - > - spin_lock_irqsave(&queue->lock, irqL); > - > - list_del_init(&precvbuf->list); > - > - list_add_tail(&precvbuf->list, get_list_head(queue)); > - spin_unlock_irqrestore(&queue->lock, irqL); > - return _SUCCESS; > -} > - > struct recv_buf *rtw_dequeue_recvbuf23a (struct rtw_queue *queue) > { > unsigned long irqL; > diff --git a/drivers/staging/rtl8723au/include/rtw_recv.h b/drivers/staging/rtl8723au/include/rtw_recv.h > index dc784be..85a5edb 100644 > --- a/drivers/staging/rtl8723au/include/rtw_recv.h > +++ b/drivers/staging/rtl8723au/include/rtw_recv.h > @@ -279,8 +279,6 @@ int rtw_enqueue_recvframe23a(struct recv_frame *precvframe, struct rtw_queue *qu > > u32 rtw_free_uc_swdec_pending_queue23a(struct rtw_adapter *adapter); > > -int rtw_enqueue_recvbuf23a_to_head(struct recv_buf *precvbuf, struct rtw_queue *queue); > -int rtw_enqueue_recvbuf23a(struct recv_buf *precvbuf, struct rtw_queue *queue); > struct recv_buf *rtw_dequeue_recvbuf23a(struct rtw_queue *queue); > > void rtw_reordering_ctrl_timeout_handler23a(unsigned long pcontext); > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Bhumika Goyal <bhumirks@gmail.com> writes: > The functions rtw_enqueue_recvbuf23a and rtw_enqueue_recvbuf23a_to_head > are never used anywhere in the kernel. So, remove their definition and > prototype. > Grepped to find occurences. > > Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> > --- > drivers/staging/rtl8723au/core/rtw_recv.c | 25 ------------------------- > drivers/staging/rtl8723au/include/rtw_recv.h | 2 -- > 2 files changed, 27 deletions(-) Looks reasonable to me. Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com> Jes > diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c b/drivers/staging/rtl8723au/core/rtw_recv.c > index 989ed07..150dabc 100644 > --- a/drivers/staging/rtl8723au/core/rtw_recv.c > +++ b/drivers/staging/rtl8723au/core/rtw_recv.c > @@ -211,31 +211,6 @@ u32 rtw_free_uc_swdec_pending_queue23a(struct rtw_adapter *adapter) > return cnt; > } > > -int rtw_enqueue_recvbuf23a_to_head(struct recv_buf *precvbuf, struct rtw_queue *queue) > -{ > - spin_lock_bh(&queue->lock); > - > - list_del_init(&precvbuf->list); > - list_add(&precvbuf->list, get_list_head(queue)); > - > - spin_unlock_bh(&queue->lock); > - > - return _SUCCESS; > -} > - > -int rtw_enqueue_recvbuf23a(struct recv_buf *precvbuf, struct rtw_queue *queue) > -{ > - unsigned long irqL; > - > - spin_lock_irqsave(&queue->lock, irqL); > - > - list_del_init(&precvbuf->list); > - > - list_add_tail(&precvbuf->list, get_list_head(queue)); > - spin_unlock_irqrestore(&queue->lock, irqL); > - return _SUCCESS; > -} > - > struct recv_buf *rtw_dequeue_recvbuf23a (struct rtw_queue *queue) > { > unsigned long irqL; > diff --git a/drivers/staging/rtl8723au/include/rtw_recv.h b/drivers/staging/rtl8723au/include/rtw_recv.h > index dc784be..85a5edb 100644 > --- a/drivers/staging/rtl8723au/include/rtw_recv.h > +++ b/drivers/staging/rtl8723au/include/rtw_recv.h > @@ -279,8 +279,6 @@ int rtw_enqueue_recvframe23a(struct recv_frame *precvframe, struct rtw_queue *qu > > u32 rtw_free_uc_swdec_pending_queue23a(struct rtw_adapter *adapter); > > -int rtw_enqueue_recvbuf23a_to_head(struct recv_buf *precvbuf, struct rtw_queue *queue); > -int rtw_enqueue_recvbuf23a(struct recv_buf *precvbuf, struct rtw_queue *queue); > struct recv_buf *rtw_dequeue_recvbuf23a(struct rtw_queue *queue); > > void rtw_reordering_ctrl_timeout_handler23a(unsigned long pcontext); -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c b/drivers/staging/rtl8723au/core/rtw_recv.c index 989ed07..150dabc 100644 --- a/drivers/staging/rtl8723au/core/rtw_recv.c +++ b/drivers/staging/rtl8723au/core/rtw_recv.c @@ -211,31 +211,6 @@ u32 rtw_free_uc_swdec_pending_queue23a(struct rtw_adapter *adapter) return cnt; } -int rtw_enqueue_recvbuf23a_to_head(struct recv_buf *precvbuf, struct rtw_queue *queue) -{ - spin_lock_bh(&queue->lock); - - list_del_init(&precvbuf->list); - list_add(&precvbuf->list, get_list_head(queue)); - - spin_unlock_bh(&queue->lock); - - return _SUCCESS; -} - -int rtw_enqueue_recvbuf23a(struct recv_buf *precvbuf, struct rtw_queue *queue) -{ - unsigned long irqL; - - spin_lock_irqsave(&queue->lock, irqL); - - list_del_init(&precvbuf->list); - - list_add_tail(&precvbuf->list, get_list_head(queue)); - spin_unlock_irqrestore(&queue->lock, irqL); - return _SUCCESS; -} - struct recv_buf *rtw_dequeue_recvbuf23a (struct rtw_queue *queue) { unsigned long irqL; diff --git a/drivers/staging/rtl8723au/include/rtw_recv.h b/drivers/staging/rtl8723au/include/rtw_recv.h index dc784be..85a5edb 100644 --- a/drivers/staging/rtl8723au/include/rtw_recv.h +++ b/drivers/staging/rtl8723au/include/rtw_recv.h @@ -279,8 +279,6 @@ int rtw_enqueue_recvframe23a(struct recv_frame *precvframe, struct rtw_queue *qu u32 rtw_free_uc_swdec_pending_queue23a(struct rtw_adapter *adapter); -int rtw_enqueue_recvbuf23a_to_head(struct recv_buf *precvbuf, struct rtw_queue *queue); -int rtw_enqueue_recvbuf23a(struct recv_buf *precvbuf, struct rtw_queue *queue); struct recv_buf *rtw_dequeue_recvbuf23a(struct rtw_queue *queue); void rtw_reordering_ctrl_timeout_handler23a(unsigned long pcontext);
The functions rtw_enqueue_recvbuf23a and rtw_enqueue_recvbuf23a_to_head are never used anywhere in the kernel. So, remove their definition and prototype. Grepped to find occurences. Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> --- drivers/staging/rtl8723au/core/rtw_recv.c | 25 ------------------------- drivers/staging/rtl8723au/include/rtw_recv.h | 2 -- 2 files changed, 27 deletions(-)