| Message ID | 1459330852-27668-11-git-send-email-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 30 March 2016 at 10:40, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > The offset manager already checks for existing offsets internally, > while holding suitable locks. We can drop this check. > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> With s/dum_map/dump_map/ in the title this is Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> -Emil
On 30 March 2016 at 11:29, Emil Velikov <emil.l.velikov@gmail.com> wrote: > On 30 March 2016 at 10:40, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: >> The offset manager already checks for existing offsets internally, >> while holding suitable locks. We can drop this check. >> >> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > With s/dum_map/dump_map/ in the title this is Or dumb_map. :) Cheers, Daniel
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c index c503a840fd88..f3ee1c41da1e 100644 --- a/drivers/gpu/drm/vgem/vgem_drv.c +++ b/drivers/gpu/drm/vgem/vgem_drv.c @@ -208,11 +208,9 @@ int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev, goto unlock; } - if (!drm_vma_node_has_offset(&obj->vma_node)) { - ret = drm_gem_create_mmap_offset(obj); - if (ret) - goto unref; - } + ret = drm_gem_create_mmap_offset(obj); + if (ret) + goto unref; BUG_ON(!obj->filp);
The offset manager already checks for existing offsets internally, while holding suitable locks. We can drop this check. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/vgem/vgem_drv.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)