diff mbox

[10/10] drm/tegra: Don't set a gamma table size

Message ID 1459331485-28376-11-git-send-email-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter March 30, 2016, 9:51 a.m. UTC
tegra doesn't have any functions to set gamma tables, so this is
completely defunct.

Not nice to lie to userspace, so let's stop!

Cc: Thierry Reding <treding@nvidia.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/tegra/dc.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Thierry Reding March 30, 2016, 12:39 p.m. UTC | #1
On Wed, Mar 30, 2016 at 11:51:25AM +0200, Daniel Vetter wrote:
> tegra doesn't have any functions to set gamma tables, so this is
> completely defunct.
> 
> Not nice to lie to userspace, so let's stop!
> 
> Cc: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/tegra/dc.c | 1 -
>  1 file changed, 1 deletion(-)

Do you want this to go through the Tegra tree or do you have follow-up
work that depends on this?

Thierry
Daniel Vetter March 30, 2016, 3:31 p.m. UTC | #2
On Wed, Mar 30, 2016 at 02:39:22PM +0200, Thierry Reding wrote:
> On Wed, Mar 30, 2016 at 11:51:25AM +0200, Daniel Vetter wrote:
> > tegra doesn't have any functions to set gamma tables, so this is
> > completely defunct.
> > 
> > Not nice to lie to userspace, so let's stop!
> > 
> > Cc: Thierry Reding <treding@nvidia.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> >  drivers/gpu/drm/tegra/dc.c | 1 -
> >  1 file changed, 1 deletion(-)
> 
> Do you want this to go through the Tegra tree or do you have follow-up
> work that depends on this?

Driver trees is fine, pls just confirm when you do so (to make sure I
don't accidentally merge it too).
-Daniel
Thierry Reding March 31, 2016, 10:33 a.m. UTC | #3
On Wed, Mar 30, 2016 at 11:51:25AM +0200, Daniel Vetter wrote:
> tegra doesn't have any functions to set gamma tables, so this is
> completely defunct.
> 
> Not nice to lie to userspace, so let's stop!
> 
> Cc: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/tegra/dc.c | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks.

Thierry
diff mbox

Patch

diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
index fb2b4b0271a2..3b85a31b625d 100644
--- a/drivers/gpu/drm/tegra/dc.c
+++ b/drivers/gpu/drm/tegra/dc.c
@@ -1722,7 +1722,6 @@  static int tegra_dc_init(struct host1x_client *client)
 	if (err < 0)
 		goto cleanup;
 
-	drm_mode_crtc_set_gamma_size(&dc->base, 256);
 	drm_crtc_helper_add(&dc->base, &tegra_crtc_helper_funcs);
 
 	/*