| Message ID | 1459352551-11773-2-git-send-email-rmanohar@qti.qualcomm.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On 03/30/2016 08:42 AM, Rajkumar Manoharan wrote: > qca99x0 and qca4019 solutions limit probe responses transmissions. > Logging warning message for each probe response drop is flooding > kernel log unnecessary with " failed to increase tx mgmt pending > count: -16, dropping". Hence reducing log level to debug. Is there any realistic way to see this message if we are not running many vAP on one radio? I guess many probe requests or other management frames could also cause this problem? Thanks, Ben > Reported-by: Sebastian Gottschall <s.gottschall@dd-wrt.com> > Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com> > --- > drivers/net/wireless/ath/ath10k/mac.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c > index ed00853..a7aafb35c 100644 > --- a/drivers/net/wireless/ath/ath10k/mac.c > +++ b/drivers/net/wireless/ath/ath10k/mac.c > @@ -3994,8 +3994,8 @@ static void ath10k_mac_op_tx(struct ieee80211_hw *hw, > > ret = ath10k_htt_tx_mgmt_inc_pending(htt, is_mgmt, is_presp); > if (ret) { > - ath10k_warn(ar, "failed to increase tx mgmt pending count: %d, dropping\n", > - ret); > + ath10k_dbg(ar, ATH10K_DBG_MAC, "failed to increase tx mgmt pending count: %d, dropping\n", > + ret); > ath10k_htt_tx_dec_pending(htt); > spin_unlock_bh(&ar->htt.tx_lock); > ieee80211_free_txskb(ar->hw, skb); >
On 2016-03-31 22:27, Ben Greear wrote: > On 03/30/2016 08:42 AM, Rajkumar Manoharan wrote: >> qca99x0 and qca4019 solutions limit probe responses transmissions. >> Logging warning message for each probe response drop is flooding >> kernel log unnecessary with " failed to increase tx mgmt pending >> count: -16, dropping". Hence reducing log level to debug. > > Is there any realistic way to see this message if we are not running > many vAP on one radio? > As of now this message can be seen only with qca99x0 which has 24 as max_probe_resp_desc_thres. Only possible way in single vAP is that in congested environment when DUT is receiving probe requests more frequently. > I guess many probe requests or other management frames could also > cause this problem? > Exactly. -Rajkumar
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index ed00853..a7aafb35c 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -3994,8 +3994,8 @@ static void ath10k_mac_op_tx(struct ieee80211_hw *hw, ret = ath10k_htt_tx_mgmt_inc_pending(htt, is_mgmt, is_presp); if (ret) { - ath10k_warn(ar, "failed to increase tx mgmt pending count: %d, dropping\n", - ret); + ath10k_dbg(ar, ATH10K_DBG_MAC, "failed to increase tx mgmt pending count: %d, dropping\n", + ret); ath10k_htt_tx_dec_pending(htt); spin_unlock_bh(&ar->htt.tx_lock); ieee80211_free_txskb(ar->hw, skb);
qca99x0 and qca4019 solutions limit probe responses transmissions. Logging warning message for each probe response drop is flooding kernel log unnecessary with " failed to increase tx mgmt pending count: -16, dropping". Hence reducing log level to debug. Reported-by: Sebastian Gottschall <s.gottschall@dd-wrt.com> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)