diff mbox

[04/14] ARM: dts: OMAP36xx: : DT spelling s/#address-cell/#address-cells/

Message ID 1461166339-11109-5-git-send-email-geert+renesas@glider.be (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Geert Uytterhoeven April 20, 2016, 3:32 p.m. UTC
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/omap36xx.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rob Herring April 20, 2016, 11:46 p.m. UTC | #1
On Wed, Apr 20, 2016 at 10:32 AM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  arch/arm/boot/dts/omap36xx.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi
> index ce1e242d4dc07ea8..8b797915300894d8 100644
> --- a/arch/arm/boot/dts/omap36xx.dtsi
> +++ b/arch/arm/boot/dts/omap36xx.dtsi
> @@ -44,7 +44,7 @@
>                 abb_mpu_iva: regulator-abb-mpu {
>                         compatible = "ti,abb-v1";
>                         regulator-name = "abb_mpu_iva";
> -                       #address-cell = <0>;
> +                       #address-cells = <0>;

dtc should flag this if it was really needed. However, it looks like
it isn't as there are no child nodes (unless the board files add
them).

A nice dtc check would be to flag unnecessary #address-cells or
#size-cells. That would only help here after your fix though.

Rob

>                         #size-cells = <0>;
>                         reg = <0x483072f0 0x8>, <0x48306818 0x4>;
>                         reg-names = "base-address", "int-address";
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren April 26, 2016, 4:08 p.m. UTC | #2
* Rob Herring <robh+dt@kernel.org> [160420 16:48]:
> On Wed, Apr 20, 2016 at 10:32 AM, Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >  arch/arm/boot/dts/omap36xx.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi
> > index ce1e242d4dc07ea8..8b797915300894d8 100644
> > --- a/arch/arm/boot/dts/omap36xx.dtsi
> > +++ b/arch/arm/boot/dts/omap36xx.dtsi
> > @@ -44,7 +44,7 @@
> >                 abb_mpu_iva: regulator-abb-mpu {
> >                         compatible = "ti,abb-v1";
> >                         regulator-name = "abb_mpu_iva";
> > -                       #address-cell = <0>;
> > +                       #address-cells = <0>;
> 
> dtc should flag this if it was really needed. However, it looks like
> it isn't as there are no child nodes (unless the board files add
> them).
> 
> A nice dtc check would be to flag unnecessary #address-cells or
> #size-cells. That would only help here after your fix though.

Yeah. Applying patches 2 - 4 into omap-for-v4.7/dt thanks.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi
index ce1e242d4dc07ea8..8b797915300894d8 100644
--- a/arch/arm/boot/dts/omap36xx.dtsi
+++ b/arch/arm/boot/dts/omap36xx.dtsi
@@ -44,7 +44,7 @@ 
 		abb_mpu_iva: regulator-abb-mpu {
 			compatible = "ti,abb-v1";
 			regulator-name = "abb_mpu_iva";
-			#address-cell = <0>;
+			#address-cells = <0>;
 			#size-cells = <0>;
 			reg = <0x483072f0 0x8>, <0x48306818 0x4>;
 			reg-names = "base-address", "int-address";