| Message ID | 57327904.1040102@sandisk.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Tue, May 10, 2016 at 05:12:52PM -0700, Bart Van Assche wrote: > pr_debug() already prints prefix PFX. Avoid that PFX is printed > twice if the debug statement in srp_add_target() is enabled. > > Fixes: 34aa654ecb8e ("IB/srp: Avoid that I/O hangs due to a cable pull during LUN scanning") > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Sagi Grimberg <sagi@grimberg.me> > Cc: Laurence Oberman <loberman@redhat.com> > Cc: <stable@vger.kernel.org> # v3.19+ Looks good, Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> pr_debug() already prints prefix PFX. Avoid that PFX is printed > twice if the debug statement in srp_add_target() is enabled. > > Fixes: 34aa654ecb8e ("IB/srp: Avoid that I/O hangs due to a cable pull during > LUN scanning") > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Sagi Grimberg <sagi@grimberg.me> > Cc: Laurence Oberman <loberman@redhat.com> > Cc: <stable@vger.kernel.org> # v3.19+ Is this really needed for stable? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/11/2016 06:24 AM, Steve Wise wrote: >> pr_debug() already prints prefix PFX. Avoid that PFX is printed >> twice if the debug statement in srp_add_target() is enabled. >> >> Fixes: 34aa654ecb8e ("IB/srp: Avoid that I/O hangs due to a cable pull during >> LUN scanning") >> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> >> Cc: Christoph Hellwig <hch@lst.de> >> Cc: Sagi Grimberg <sagi@grimberg.me> >> Cc: Laurence Oberman <loberman@redhat.com> >> Cc: <stable@vger.kernel.org> # v3.19+ > > Is this really needed for stable? Hello Steve, Since this patch touches a debug statement only I'm fine with not CC-ing stable for this patch. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index caefd1a..e088a49 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b/drivers/infiniband/ulp/srp/ib_srp.c @@ -2839,7 +2839,7 @@ static int srp_add_target(struct srp_host *host, struct srp_target_port *target) goto out; } - pr_debug(PFX "%s: SCSI scan succeeded - detected %d LUNs\n", + pr_debug("%s: SCSI scan succeeded - detected %d LUNs\n", dev_name(&target->scsi_host->shost_gendev), srp_sdev_count(target->scsi_host));
pr_debug() already prints prefix PFX. Avoid that PFX is printed twice if the debug statement in srp_add_target() is enabled. Fixes: 34aa654ecb8e ("IB/srp: Avoid that I/O hangs due to a cable pull during LUN scanning") Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Sagi Grimberg <sagi@grimberg.me> Cc: Laurence Oberman <loberman@redhat.com> Cc: <stable@vger.kernel.org> # v3.19+ --- drivers/infiniband/ulp/srp/ib_srp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)