| Message ID | 33c3370d-3568-a9aa-906f-683b0e1b1a5f@sandisk.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, Jun 03, 2016 at 07:58:32AM -0700, Bart Van Assche wrote: > Perform the test for device managed flow steering support even if > memory windows are not supported. I noticed this because smatch > reported inconsistent indentation for the device managed flow > steering support test. > > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> > Reviewed-by: Sagi Grimberg <sagi@grimberg.me> > Cc: Yishai Hadas <yishaih@mellanox.com> Thanks Bart, Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> -----Original Message----- > From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma- > owner@vger.kernel.org] On Behalf Of Bart Van Assche > Sent: Friday, June 03, 2016 9:59 AM > To: Doug Ledford > Cc: Sagi Grimberg; Yishai Hadas; leon@kernel.org; linux-rdma@vger.kernel.org > Subject: [PATCH] IB/mlx4: Fix device managed flow steering support test > > Perform the test for device managed flow steering support even if > memory windows are not supported. I noticed this because smatch > reported inconsistent indentation for the device managed flow > steering support test. > > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> > Reviewed-by: Sagi Grimberg <sagi@grimberg.me> > Cc: Yishai Hadas <yishaih@mellanox.com> Is there a commit you can reference with a Fixes line? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/03/2016 08:22 AM, Steve Wise wrote: >> -----Original Message----- >> From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma- >> owner@vger.kernel.org] On Behalf Of Bart Van Assche >> Sent: Friday, June 03, 2016 9:59 AM >> To: Doug Ledford >> Cc: Sagi Grimberg; Yishai Hadas; leon@kernel.org; linux-rdma@vger.kernel.org >> Subject: [PATCH] IB/mlx4: Fix device managed flow steering support test >> >> Perform the test for device managed flow steering support even if >> memory windows are not supported. I noticed this because smatch >> reported inconsistent indentation for the device managed flow >> steering support test. >> >> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> >> Reviewed-by: Sagi Grimberg <sagi@grimberg.me> >> Cc: Yishai Hadas <yishaih@mellanox.com> > > Is there a commit you can reference with a Fixes line? Hello Steve, I'm not sure it's worth to add that information. A quote from an e-mail that was posted yesterday on this mailing list: "It looks like an unharmful issue with the code, because we had support for memory window feature literally forever." Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 6/3/2016 10:58 AM, Bart Van Assche wrote: > Perform the test for device managed flow steering support even if > memory windows are not supported. I noticed this because smatch > reported inconsistent indentation for the device managed flow > steering support test. > > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> > Reviewed-by: Sagi Grimberg <sagi@grimberg.me> > Cc: Yishai Hadas <yishaih@mellanox.com> > --- > drivers/infiniband/hw/mlx4/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c > index b01ef6e..0eb09e1 100644 > --- a/drivers/infiniband/hw/mlx4/main.c > +++ b/drivers/infiniband/hw/mlx4/main.c > @@ -505,9 +505,9 @@ static int mlx4_ib_query_device(struct ib_device *ibdev, > props->device_cap_flags |= IB_DEVICE_MEM_WINDOW_TYPE_2B; > else > props->device_cap_flags |= IB_DEVICE_MEM_WINDOW_TYPE_2A; > - if (dev->steering_support == MLX4_STEERING_MODE_DEVICE_MANAGED) > - props->device_cap_flags |= IB_DEVICE_MANAGED_FLOW_STEERING; > } > + if (dev->steering_support == MLX4_STEERING_MODE_DEVICE_MANAGED) > + props->device_cap_flags |= IB_DEVICE_MANAGED_FLOW_STEERING; > > props->device_cap_flags |= IB_DEVICE_RAW_IP_CSUM; > > Thanks Bart, applied.
diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c index b01ef6e..0eb09e1 100644 --- a/drivers/infiniband/hw/mlx4/main.c +++ b/drivers/infiniband/hw/mlx4/main.c @@ -505,9 +505,9 @@ static int mlx4_ib_query_device(struct ib_device *ibdev, props->device_cap_flags |= IB_DEVICE_MEM_WINDOW_TYPE_2B; else props->device_cap_flags |= IB_DEVICE_MEM_WINDOW_TYPE_2A; - if (dev->steering_support == MLX4_STEERING_MODE_DEVICE_MANAGED) - props->device_cap_flags |= IB_DEVICE_MANAGED_FLOW_STEERING; } + if (dev->steering_support == MLX4_STEERING_MODE_DEVICE_MANAGED) + props->device_cap_flags |= IB_DEVICE_MANAGED_FLOW_STEERING; props->device_cap_flags |= IB_DEVICE_RAW_IP_CSUM;