diff mbox

[26/27] drm/hisilicon: Use lockless gem BO free callback

Message ID 1464630800-30786-27-git-send-email-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter May 30, 2016, 5:53 p.m. UTC 
No dev->struct_mutex anywhere to be seen.

Cc: Xinliang Liu <xinliang.liu@linaro.org>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Xinliang Liu May 31, 2016, 1:14 a.m. UTC | #1 
Hi, thanks for your patch.

On 31 May 2016 at 01:53, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> No dev->struct_mutex anywhere to be seen.
>
> Cc: Xinliang Liu <xinliang.liu@linaro.org>
> Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
> index 3f94785fbcca..193657259ee9 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
> @@ -173,7 +173,7 @@ static struct drm_driver kirin_drm_driver = {
>         .fops                   = &kirin_drm_fops,
>         .set_busid              = drm_platform_set_busid,
>
> -       .gem_free_object        = drm_gem_cma_free_object,
> +       .gem_free_object_unlocked = drm_gem_cma_free_object,

This patch looks good to me apply to drm-hisilicon-next.
Thanks,
-xinliang

>         .gem_vm_ops             = &drm_gem_cma_vm_ops,
>         .dumb_create            = kirin_gem_cma_dumb_create,
>         .dumb_map_offset        = drm_gem_cma_dumb_map_offset,
> --
> 2.8.1
>
Xinliang Liu June 12, 2016, 9:48 a.m. UTC | #2 
Hi,

On 31 May 2016 at 01:53, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> No dev->struct_mutex anywhere to be seen.
>
> Cc: Xinliang Liu <xinliang.liu@linaro.org>
> Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Reviewed-by: Xinliang Liu <xinliang.liu@linaro.org>

> ---
>  drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
> index 3f94785fbcca..193657259ee9 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
> @@ -173,7 +173,7 @@ static struct drm_driver kirin_drm_driver = {
>         .fops                   = &kirin_drm_fops,
>         .set_busid              = drm_platform_set_busid,
>
> -       .gem_free_object        = drm_gem_cma_free_object,
> +       .gem_free_object_unlocked = drm_gem_cma_free_object,
>         .gem_vm_ops             = &drm_gem_cma_vm_ops,
>         .dumb_create            = kirin_gem_cma_dumb_create,
>         .dumb_map_offset        = drm_gem_cma_dumb_map_offset,
> --
> 2.8.1
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
index 3f94785fbcca..193657259ee9 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
@@ -173,7 +173,7 @@  static struct drm_driver kirin_drm_driver = {
 	.fops			= &kirin_drm_fops,
 	.set_busid		= drm_platform_set_busid,
 
-	.gem_free_object	= drm_gem_cma_free_object,
+	.gem_free_object_unlocked = drm_gem_cma_free_object,
 	.gem_vm_ops		= &drm_gem_cma_vm_ops,
 	.dumb_create		= kirin_gem_cma_dumb_create,
 	.dumb_map_offset	= drm_gem_cma_dumb_map_offset,