| Message ID | 20160623151328.24061-3-martin.blumenstingl@googlemail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
On Thursday, June 23, 2016 05:13:28 PM Martin Blumenstingl wrote: > Add documentation how devicetree can be used to configure ath9k based > devices. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> You need to CC' the devicetree maintainers: Mark Rutland <mark.rutland@arm.com> Rob Herring <robh+dt@kernel.org> devicetree@vger.kernel.org for all patches which touch Documentation/devicetree/... . Also, I know (from experience) that they would prefer it, if you put the device tree binding patch at the top of the series (i.e. make it: [PATCH 1/2] dt-bindings...). ;-) > --- > .../devicetree/bindings/net/wireless/ath,ath9k.txt | 40 ++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/ath,ath9k.txt > > diff --git a/Documentation/devicetree/bindings/net/wireless/ath,ath9k.txt b/Documentation/devicetree/bindings/net/wireless/ath,ath9k.txt > new file mode 100644 > index 0000000..d6f5471 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/ath,ath9k.txt > @@ -0,0 +1,40 @@ > +* Atheros ath9k wireless devices > + > +This node provides properties for configuring the ath9k wireless device. The > +node is expected to be specified as a child node of the PCI controller to > +which the wireless chip is connected. > + > +Required properties: > +- compatible: Should be "ath,ath9k" Documentation/devicetree/bindings/vendor-prefixes.txt has an entry for Qualcomm Atheros, Inc. => qca. I would use that instead, given that this is a new binding, so there's '"no"' legacy code to worry about. > + > +Optional properties: > +- reg: Address and length of the register set for the device. > +- ath,gpio-mask: The GPIO mask > +- ath,gpio-val: The GPIO value > +- ath,led-pin: The GPIO number to which the LED is connected > +- ath,led-active-high: The LED is active when the GPIO is HIGH > +- ath,clk-25mhz: Defines that at 25MHz clock is used > +- ath,eeprom-name: The name of the file which contains the EEPROM data (which > + will be loaded via request_firmware) > +- ath,check-eeprom-endianness: Allow checking the EEPROM endianness and > + swapping of the EEPROM data if required > +- ath,disable-2ghz: Disables the 2.4GHz band, even if enabled in the EEPROM > +- ath,disable-5ghz: Disables the 5GHz band, even if enabled in the EEPROM > + > +In this example, the node is defined as child node of the PCI controller. > + > +pci { > + pcie@0 { > + reg = <0 0 0 0 0>; > + #interrupt-cells = <1>; > + #size-cells = <2>; > + #address-cells = <3>; > + device_type = "pci"; > + > + ath9k@0,0 { compatible = "qca,ath9k"; ? > + reg = <0 0 0 0 0>; > + device_type = "pci"; > + ath,disable-5ghz; > + }; > + }; > +}; > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/net/wireless/ath,ath9k.txt b/Documentation/devicetree/bindings/net/wireless/ath,ath9k.txt new file mode 100644 index 0000000..d6f5471 --- /dev/null +++ b/Documentation/devicetree/bindings/net/wireless/ath,ath9k.txt @@ -0,0 +1,40 @@ +* Atheros ath9k wireless devices + +This node provides properties for configuring the ath9k wireless device. The +node is expected to be specified as a child node of the PCI controller to +which the wireless chip is connected. + +Required properties: +- compatible: Should be "ath,ath9k" + +Optional properties: +- reg: Address and length of the register set for the device. +- ath,gpio-mask: The GPIO mask +- ath,gpio-val: The GPIO value +- ath,led-pin: The GPIO number to which the LED is connected +- ath,led-active-high: The LED is active when the GPIO is HIGH +- ath,clk-25mhz: Defines that at 25MHz clock is used +- ath,eeprom-name: The name of the file which contains the EEPROM data (which + will be loaded via request_firmware) +- ath,check-eeprom-endianness: Allow checking the EEPROM endianness and + swapping of the EEPROM data if required +- ath,disable-2ghz: Disables the 2.4GHz band, even if enabled in the EEPROM +- ath,disable-5ghz: Disables the 5GHz band, even if enabled in the EEPROM + +In this example, the node is defined as child node of the PCI controller. + +pci { + pcie@0 { + reg = <0 0 0 0 0>; + #interrupt-cells = <1>; + #size-cells = <2>; + #address-cells = <3>; + device_type = "pci"; + + ath9k@0,0 { + reg = <0 0 0 0 0>; + device_type = "pci"; + ath,disable-5ghz; + }; + }; +};
Add documentation how devicetree can be used to configure ath9k based devices. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- .../devicetree/bindings/net/wireless/ath,ath9k.txt | 40 ++++++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/ath,ath9k.txt