| Message ID | 20160624123430.4097-2-martin.blumenstingl@googlemail.com (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Kalle Valo |
| Headers | show |
Hi Martin, On Fri, Jun 24, 2016 at 10:34 PM, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > Add documentation how devicetree can be used to configure ath9k based > devices. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > changes in v2 -> v3: > - improved wording of the qca,disable-2ghz and qca,disable-5ghz properties > - replaced qca,eeprom-name with qca,no-eeprom (the eeprom name is now > built automatically within ath9k). The naming was chosen to stay > consistent with other drivers (such as davicom-dm9000 and via-velocity) > - added reference to the mac-address and local-mac-address properties > - removed invalid device_type property from the example > > .../devicetree/bindings/net/wireless/qca,ath9k.txt | 46 ++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/qca,ath9k.txt > > diff --git a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.txt b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.txt > new file mode 100644 > index 0000000..ff83fd4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.txt > @@ -0,0 +1,46 @@ > +* Qualcomm Atheros ath9k wireless devices > + > +This node provides properties for configuring the ath9k wireless device. The > +node is expected to be specified as a child node of the PCI controller to > +which the wireless chip is connected. > + > +Required properties: > +- compatible: Should be "qca,ath9k" > + > +Optional properties: > +- reg: Address and length of the register set for the device. > +- qca,gpio-mask: The GPIO mask > +- qca,gpio-val: The GPIO value > +- qca,led-pin: The GPIO number to which the LED is connected > +- qca,led-active-high: The LED is active when the GPIO is HIGH > +- qca,clk-25mhz: Defines that at 25MHz clock is used > +- qca,no-eeprom: Indicates that there is on physical EEPROM connected Typo: ...Indicates that there is _no_ physical EEPROM... Thanks,
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes: > Add documentation how devicetree can be used to configure ath9k based > devices. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > changes in v2 -> v3: > - improved wording of the qca,disable-2ghz and qca,disable-5ghz properties > - replaced qca,eeprom-name with qca,no-eeprom (the eeprom name is now > built automatically within ath9k). The naming was chosen to stay > consistent with other drivers (such as davicom-dm9000 and via-velocity) > - added reference to the mac-address and local-mac-address properties > - removed invalid device_type property from the example > > .../devicetree/bindings/net/wireless/qca,ath9k.txt | 46 ++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/qca,ath9k.txt For device tree bindings document changes you should CC the device tree list: $ scripts/get_maintainer.pl -f Documentation/devicetree/bindings/net/wireless/ Kalle Valo <kvalo@codeaurora.org> (maintainer:NETWORKING DRIVERS (WIRELESS)) Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Mark Rutland <mark.rutland@arm.com> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) linux-wireless@vger.kernel.org (open list:NETWORKING DRIVERS (WIRELESS)) netdev@vger.kernel.org (open list:NETWORKING DRIVERS) devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) linux-kernel@vger.kernel.org (open list)
diff --git a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.txt b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.txt new file mode 100644 index 0000000..ff83fd4 --- /dev/null +++ b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.txt @@ -0,0 +1,46 @@ +* Qualcomm Atheros ath9k wireless devices + +This node provides properties for configuring the ath9k wireless device. The +node is expected to be specified as a child node of the PCI controller to +which the wireless chip is connected. + +Required properties: +- compatible: Should be "qca,ath9k" + +Optional properties: +- reg: Address and length of the register set for the device. +- qca,gpio-mask: The GPIO mask +- qca,gpio-val: The GPIO value +- qca,led-pin: The GPIO number to which the LED is connected +- qca,led-active-high: The LED is active when the GPIO is HIGH +- qca,clk-25mhz: Defines that at 25MHz clock is used +- qca,no-eeprom: Indicates that there is on physical EEPROM connected + to the ath9k wireless chip (in this case the + calibration / EEPROM data will be loaded from + userspace using the firmware mechanism) +- qca,check-eeprom-endianness: Allow checking the EEPROM endianness and + swapping of the EEPROM data if required +- qca,disable-2ghz: Overrides the settings from the EEPROM and disables + the 2.4GHz band, even if enabled in the EEPROM +- qca,disable-5ghz: Overrides the settings from the EEPROM and disables + the 5GHz band, even if enabled in the EEPROM +- mac-address: See ethernet.txt in the parent directory +- local-mac-address: See ethernet.txt in the parent directory + +In this example, the node is defined as child node of the PCI controller. + +pci { + pcie@0 { + reg = <0 0 0 0 0>; + #interrupt-cells = <1>; + #size-cells = <2>; + #address-cells = <3>; + device_type = "pci"; + + ath9k@0,0 { + compatible = "qca,ath9k"; + reg = <0 0 0 0 0>; + qca,disable-5ghz; + }; + }; +};
Add documentation how devicetree can be used to configure ath9k based devices. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- changes in v2 -> v3: - improved wording of the qca,disable-2ghz and qca,disable-5ghz properties - replaced qca,eeprom-name with qca,no-eeprom (the eeprom name is now built automatically within ath9k). The naming was chosen to stay consistent with other drivers (such as davicom-dm9000 and via-velocity) - added reference to the mac-address and local-mac-address properties - removed invalid device_type property from the example .../devicetree/bindings/net/wireless/qca,ath9k.txt | 46 ++++++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/qca,ath9k.txt