| Message ID | 20160629143056.7405-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Hi, On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote: > Building the smbb driver without extcon results in a link failure: > > drivers/power/built-in.o: In function `smbb_usb_valid_handler': > :(.text+0x3190): undefined reference to `extcon_set_cable_state_' > drivers/power/built-in.o: In function `smbb_charger_probe': > :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate' > :(.text+0x3898): undefined reference to `devm_extcon_dev_register' > > This adds a Kconfig dependency. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver") > --- > drivers/power/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig > index 0f11a0f4c369..acd4a1524a1e 100644 > --- a/drivers/power/Kconfig > +++ b/drivers/power/Kconfig > @@ -394,6 +394,7 @@ config CHARGER_QCOM_SMBB > tristate "Qualcomm Switch-Mode Battery Charger and Boost" > depends on MFD_SPMI_PMIC || COMPILE_TEST > depends on OF > + depends on EXTCON > help > Say Y to include support for the Switch-Mode Battery Charger and > Boost (SMBB) hardware found in Qualcomm PM8941 PMICs. The charger Thanks, queued. -- Sebastian
On 06/29/2016 07:38 AM, Sebastian Reichel wrote: > Hi, > > On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote: >> Building the smbb driver without extcon results in a link failure: >> >> drivers/power/built-in.o: In function `smbb_usb_valid_handler': >> :(.text+0x3190): undefined reference to `extcon_set_cable_state_' >> drivers/power/built-in.o: In function `smbb_charger_probe': >> :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate' >> :(.text+0x3898): undefined reference to `devm_extcon_dev_register' >> >> This adds a Kconfig dependency. >> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver") extcon use was only recently introduced so this should be Fixes: 0b7fe26ae602 ("power: qcom_smbb: Make an extcon for usb cable detection")
Hi, On Wed, Jun 29, 2016 at 11:10:34AM -0700, Stephen Boyd wrote: > On 06/29/2016 07:38 AM, Sebastian Reichel wrote: > > On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote: > >> Building the smbb driver without extcon results in a link failure: > >> > >> drivers/power/built-in.o: In function `smbb_usb_valid_handler': > >> :(.text+0x3190): undefined reference to `extcon_set_cable_state_' > >> drivers/power/built-in.o: In function `smbb_charger_probe': > >> :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate' > >> :(.text+0x3898): undefined reference to `devm_extcon_dev_register' > >> > >> This adds a Kconfig dependency. > >> > >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > >> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver") > > extcon use was only recently introduced so this should be > > Fixes: 0b7fe26ae602 ("power: qcom_smbb: Make an extcon for usb cable > detection") Right, I didn't notice the Fixes line is wrong. Since I will have to rebase now, I will just squash this into 0b7fe26ae602. -- Sebastian
On Wednesday, June 29, 2016 11:09:58 PM CEST Sebastian Reichel wrote: > On Wed, Jun 29, 2016 at 11:10:34AM -0700, Stephen Boyd wrote: > > On 06/29/2016 07:38 AM, Sebastian Reichel wrote: > > > On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote: > > >> Building the smbb driver without extcon results in a link failure: > > >> > > >> drivers/power/built-in.o: In function `smbb_usb_valid_handler': > > >> :(.text+0x3190): undefined reference to `extcon_set_cable_state_' > > >> drivers/power/built-in.o: In function `smbb_charger_probe': > > >> :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate' > > >> :(.text+0x3898): undefined reference to `devm_extcon_dev_register' > > >> > > >> This adds a Kconfig dependency. > > >> > > >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > >> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver") > > > > extcon use was only recently introduced so this should be > > > > Fixes: 0b7fe26ae602 ("power: qcom_smbb: Make an extcon for usb cable > > detection") > > Right, I didn't notice the Fixes line is wrong. Since I will have to > rebase now, I will just squash this into 0b7fe26ae602. Ok, thanks and sorry for the mixup, I must have pasted the wrong line. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig index 0f11a0f4c369..acd4a1524a1e 100644 --- a/drivers/power/Kconfig +++ b/drivers/power/Kconfig @@ -394,6 +394,7 @@ config CHARGER_QCOM_SMBB tristate "Qualcomm Switch-Mode Battery Charger and Boost" depends on MFD_SPMI_PMIC || COMPILE_TEST depends on OF + depends on EXTCON help Say Y to include support for the Switch-Mode Battery Charger and Boost (SMBB) hardware found in Qualcomm PM8941 PMICs. The charger
Building the smbb driver without extcon results in a link failure: drivers/power/built-in.o: In function `smbb_usb_valid_handler': :(.text+0x3190): undefined reference to `extcon_set_cable_state_' drivers/power/built-in.o: In function `smbb_charger_probe': :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate' :(.text+0x3898): undefined reference to `devm_extcon_dev_register' This adds a Kconfig dependency. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver") --- drivers/power/Kconfig | 1 + 1 file changed, 1 insertion(+)