| Message ID | 1467995301-14226-3-git-send-email-xose.vazquez@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Thanks Xose. These changes are good with Debian. Ritesh On Fri, 2016-07-08 at 18:28 +0200, Xose Vazquez Perez wrote: > OPTFLAGS is not used anywhere, but maybe it's intrusive for distributions. > > Cc: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com> > Cc: Dragan Stancevic <dragan.stancevic@canonical.com> > Cc: Louis Bouchard <louis.bouchard@canonical.com> > Cc: Ritesh Raj Sarraf <rrs@debian.org> > Cc: Benjamin Marzinski <bmarzins@redhat.com> > Cc: Hannes Reinecke <hare@suse.de> > Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> > Cc: device-mapper development <dm-devel@redhat.com> > Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> > --- > Makefile.inc | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/Makefile.inc b/Makefile.inc > index 01d743c..b7077fc 100644 > --- a/Makefile.inc > +++ b/Makefile.inc > @@ -60,10 +60,9 @@ RM = rm -f > LN = ln -sf > INSTALL_PROGRAM = install > > -OPTFLAGS = -Wunused -Wstrict-prototypes -O2 -g -pipe -Wformat-security > -Wall \ > - -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector -- > param=ssp-buffer-size=4 > - > -CFLAGS = $(OPTFLAGS) -fPIC -DLIB_STRING=\"${LIB}\" > -DRUN_DIR=\"${RUN}\" > +CFLAGS = -Wunused -Wstrict-prototypes -O2 -g -pipe -Wformat-security > -Wall \ > + -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector -- > param=ssp-buffer-size=4 \ > + -fPIC -DLIB_STRING=\"${LIB}\" -DRUN_DIR=\"${RUN}\" > SHARED_FLAGS = -shared > > %.o: %.c - -- Ritesh Raj Sarraf | http://people.debian.org/~rrs Debian - The Universal Operating System -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJXgMGjAAoJEKY6WKPy4XVps3IP/i8WjCdrGN/bhfpQgrt9wE09 JzYcLtqHMoUv3tT+YqJW3vpNgAn5UIujKkMogYbp5krvfG9MP4YFL0Vn4wI3EBTm XXRnaBumHzE+QYhec7WnlTLEcv1RExyvyx8V1cqX7fFCzZfQGmjmoFQDL1CPN82Z XbY0QfZWHBbpkNn57P7oCNGqnbL0IyqvVnNcTxmczALgySmp59w8WIS72kSiwMEH mAgfYZ1Feql8Q1mQu1cQN8pPcFZgK0M4r2RtZ0SiQcQVtXVCDuhWCMQzV1eEvhPL tAg78AJjnLFMDR8k9spKaGdLoyef7lTtxxUxyM6hEs08IpqxgedYD2lZvjqLNQmG QTkkDfqDRnf+qeLuJMTxRCJavAXVO1f29ukynJ2Tm98LElxDEuW9UP10hGUHGA5U KyBt/fCW9AUr0uTqO95+SCcHhNMyLuqDP5rZVJ7hCcbUtzGTbrAlQ8LIbX6BYDAc tTTn27ZqGtQkV4h49YjIzhX8csCzrYejyI6ltIuKiePIPba2QnjaRp65C0zsR4IM Gy7hvmugVIY7vMTFev9nk3qIgzu5kY6tA15Mw39o7Fc8uRyrFytmfX6Pzsv/OKCx WKNpUYf3C5rU8OOdQ73fT2dEmb++rS99SB7Z0jEAAT9OCeDp+ffB+FVtm7rhohSF lUrdul6jSduwV2pSlA5s =NVXI -----END PGP SIGNATURE----- -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
On 07/08/2016 06:28 PM, Xose Vazquez Perez wrote: > OPTFLAGS is not used anywhere, but maybe it's intrusive for distributions. > > Cc: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com> > Cc: Dragan Stancevic <dragan.stancevic@canonical.com> > Cc: Louis Bouchard <louis.bouchard@canonical.com> > Cc: Ritesh Raj Sarraf <rrs@debian.org> > Cc: Benjamin Marzinski <bmarzins@redhat.com> > Cc: Hannes Reinecke <hare@suse.de> > Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> > Cc: device-mapper development <dm-devel@redhat.com> > Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> > --- > Makefile.inc | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/Makefile.inc b/Makefile.inc > index 01d743c..b7077fc 100644 > --- a/Makefile.inc > +++ b/Makefile.inc > @@ -60,10 +60,9 @@ RM = rm -f > LN = ln -sf > INSTALL_PROGRAM = install > > -OPTFLAGS = -Wunused -Wstrict-prototypes -O2 -g -pipe -Wformat-security -Wall \ > - -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 > - > -CFLAGS = $(OPTFLAGS) -fPIC -DLIB_STRING=\"${LIB}\" -DRUN_DIR=\"${RUN}\" > +CFLAGS = -Wunused -Wstrict-prototypes -O2 -g -pipe -Wformat-security -Wall \ > + -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 \ > + -fPIC -DLIB_STRING=\"${LIB}\" -DRUN_DIR=\"${RUN}\" > SHARED_FLAGS = -shared > > %.o: %.c > Nope, doesn't work for us. Our buildsystem is using a distinct set of flags, which we need to use for the build process. At the same time we have no idea if there are other flags (like includes etc) which are required by the build itself. Please revert, this breaks our build. Cheers, Hannes
Reverted. On Fri, Jul 15, 2016 at 12:19 PM, Hannes Reinecke <hare@suse.de> wrote: > On 07/08/2016 06:28 PM, Xose Vazquez Perez wrote: > > OPTFLAGS is not used anywhere, but maybe it's intrusive for > distributions. > > > > Cc: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com> > > Cc: Dragan Stancevic <dragan.stancevic@canonical.com> > > Cc: Louis Bouchard <louis.bouchard@canonical.com> > > Cc: Ritesh Raj Sarraf <rrs@debian.org> > > Cc: Benjamin Marzinski <bmarzins@redhat.com> > > Cc: Hannes Reinecke <hare@suse.de> > > Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> > > Cc: device-mapper development <dm-devel@redhat.com> > > Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> > > --- > > Makefile.inc | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/Makefile.inc b/Makefile.inc > > index 01d743c..b7077fc 100644 > > --- a/Makefile.inc > > +++ b/Makefile.inc > > @@ -60,10 +60,9 @@ RM = rm -f > > LN = ln -sf > > INSTALL_PROGRAM = install > > > > -OPTFLAGS = -Wunused -Wstrict-prototypes -O2 -g -pipe > -Wformat-security -Wall \ > > - -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector > --param=ssp-buffer-size=4 > > - > > -CFLAGS = $(OPTFLAGS) -fPIC -DLIB_STRING=\"${LIB}\" > -DRUN_DIR=\"${RUN}\" > > +CFLAGS = -Wunused -Wstrict-prototypes -O2 -g -pipe > -Wformat-security -Wall \ > > + -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector > --param=ssp-buffer-size=4 \ > > + -fPIC -DLIB_STRING=\"${LIB}\" -DRUN_DIR=\"${RUN}\" > > SHARED_FLAGS = -shared > > > > %.o: %.c > > > Nope, doesn't work for us. > Our buildsystem is using a distinct set of flags, which we need to use > for the build process. > At the same time we have no idea if there are other flags (like includes > etc) which are required by the build itself. > > Please revert, this breaks our build. > > Cheers, > > Hannes > -- > Dr. Hannes Reinecke Teamlead Storage & Networking > hare@suse.de +49 911 74053 688 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton > HRB 21284 (AG Nürnberg) > -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
diff --git a/Makefile.inc b/Makefile.inc index 01d743c..b7077fc 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -60,10 +60,9 @@ RM = rm -f LN = ln -sf INSTALL_PROGRAM = install -OPTFLAGS = -Wunused -Wstrict-prototypes -O2 -g -pipe -Wformat-security -Wall \ - -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 - -CFLAGS = $(OPTFLAGS) -fPIC -DLIB_STRING=\"${LIB}\" -DRUN_DIR=\"${RUN}\" +CFLAGS = -Wunused -Wstrict-prototypes -O2 -g -pipe -Wformat-security -Wall \ + -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 \ + -fPIC -DLIB_STRING=\"${LIB}\" -DRUN_DIR=\"${RUN}\" SHARED_FLAGS = -shared %.o: %.c
OPTFLAGS is not used anywhere, but maybe it's intrusive for distributions. Cc: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com> Cc: Dragan Stancevic <dragan.stancevic@canonical.com> Cc: Louis Bouchard <louis.bouchard@canonical.com> Cc: Ritesh Raj Sarraf <rrs@debian.org> Cc: Benjamin Marzinski <bmarzins@redhat.com> Cc: Hannes Reinecke <hare@suse.de> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> Cc: device-mapper development <dm-devel@redhat.com> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> --- Makefile.inc | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)