| Message ID | 20160703173040.23612-2-paul.gortmaker@windriver.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/03/2016 10:30 AM, Paul Gortmaker wrote: > The Kconfig for this driver is currently: > > config BRCMSTB_GISB_ARB > bool "Broadcom STB GISB bus arbiter" > > ...meaning that it currently is not being built as a module by anyone. > Lets remove all modular references, so that when reading the driver > there is no doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > Cc: Brian Norris <computersforpeace@gmail.com> > Acked-by: Brian Norris <computersforpeace@gmail.com> > Cc: Gregory Fong <gregory.0xf0@gmail.com> > Cc: Florian Fainelli <f.fainelli@gmail.com> > Acked-by: Florian Fainelli <f.fainelli@gmail.com> > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Applied to drivers/next, thanks Paul -- Florian
diff --git a/drivers/bus/brcmstb_gisb.c b/drivers/bus/brcmstb_gisb.c index 72fe0a5a8bf3..2616d8208777 100644 --- a/drivers/bus/brcmstb_gisb.c +++ b/drivers/bus/brcmstb_gisb.c @@ -13,7 +13,6 @@ #include <linux/init.h> #include <linux/types.h> -#include <linux/module.h> #include <linux/platform_device.h> #include <linux/interrupt.h> #include <linux/sysfs.h> @@ -438,5 +437,4 @@ static int __init brcm_gisb_driver_init(void) return platform_driver_probe(&brcmstb_gisb_arb_driver, brcmstb_gisb_arb_probe); } - -module_init(brcm_gisb_driver_init); +device_initcall(brcm_gisb_driver_init);
The Kconfig for this driver is currently: config BRCMSTB_GISB_ARB bool "Broadcom STB GISB bus arbiter" ...meaning that it currently is not being built as a module by anyone. Lets remove all modular references, so that when reading the driver there is no doubt it is builtin-only. Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit. Cc: Brian Norris <computersforpeace@gmail.com> Acked-by: Brian Norris <computersforpeace@gmail.com> Cc: Gregory Fong <gregory.0xf0@gmail.com> Cc: Florian Fainelli <f.fainelli@gmail.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com> Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- drivers/bus/brcmstb_gisb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)