diff mbox

ath6kl: sme_state shortcut to SME_DISCONNECTED removed

Message ID 1468026259-25148-1-git-send-email-dan.kephart@lairdtech.com (mailing list archive)
State Accepted
Commit 42e54152e7070f53294fc41d7f12749ba8bf9aab
Delegated to: Kalle Valo
Headers show

Commit Message

engineering@keppy.com July 9, 2016, 1:04 a.m. UTC 
From: Dan Kephart <dan.kephart@lairdtech.com>

When an NL80211_DISCONNECT is sent to cfg80211, the driver's cfg80211
disconnect function sets the sme_state to SME_DISCONNECTED before receiving
a WMI_DISCONNECT_EVENT from the firmware.  This caused cfg80211 to not know
that the connection is disconnected because the driver fails to notify
cfg80211 upon receiving WMI_DISCONNECT_EVENT from the firmware believing
it is already disconnected.

Signed-off-by: Dan Kephart <dan.kephart@lairdtech.com>
---
 drivers/net/wireless/ath/ath6kl/cfg80211.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Kalle Valo July 19, 2016, 5:56 p.m. UTC | #1 
engineering@keppy.com wrote:
> From: Dan Kephart <dan.kephart@lairdtech.com>
> 
> When an NL80211_DISCONNECT is sent to cfg80211, the driver's cfg80211
> disconnect function sets the sme_state to SME_DISCONNECTED before receiving
> a WMI_DISCONNECT_EVENT from the firmware.  This caused cfg80211 to not know
> that the connection is disconnected because the driver fails to notify
> cfg80211 upon receiving WMI_DISCONNECT_EVENT from the firmware believing
> it is already disconnected.
> 
> Signed-off-by: Dan Kephart <dan.kephart@lairdtech.com>

Thanks, 1 patch applied to ath-next branch of ath.git:

42e54152e707 ath6kl: sme_state shortcut to SME_DISCONNECTED removed
diff mbox

Patch

diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index ef5b40e..86a860f 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -847,8 +847,6 @@  static int ath6kl_cfg80211_disconnect(struct wiphy *wiphy,
 
 	up(&ar->sem);
 
-	vif->sme_state = SME_DISCONNECTED;
-
 	return 0;
 }