diff mbox

generic/294: fix _filter_mknod quoting

Message ID efc1c8a69bb7d09412342841e340b51a709dee63.1469565411.git.osandov@fb.com (mailing list archive)
State New, archived
Headers show

Commit Message

Omar Sandoval July 26, 2016, 8:39 p.m. UTC 
From: Omar Sandoval <osandov@fb.com>

Coreutils 8.4 uses a back tick instead of a single quote when quoting a
file name. That means that _filter_mknod doesn't properly filter the
error message from mknod.

Signed-off-by: Omar Sandoval <osandov@fb.com>
---
 common/filter | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eryu Guan July 27, 2016, 2:30 p.m. UTC | #1 
On Tue, Jul 26, 2016 at 01:39:26PM -0700, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
> 
> Coreutils 8.4 uses a back tick instead of a single quote when quoting a
> file name. That means that _filter_mknod doesn't properly filter the
> error message from mknod.
> 
> Signed-off-by: Omar Sandoval <osandov@fb.com>

This has been fixed by Jan Kara in latest fstests update.

[9b06a9f] generic/294: Filter backquotes from mknod error output

Thanks for the follow up!

Eryu
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/common/filter b/common/filter
index 8d9f489bea1c..886ab6deae55 100644
--- a/common/filter
+++ b/common/filter
@@ -389,7 +389,7 @@  _filter_od()
 # mknod errors print unquoted filenames
 _filter_mknod()
 {
-	sed -e "s/mknod: '\(.*\)': File exists/mknod: \1: File exists/"
+	sed -e "s/mknod: ['\`]\(.*\)': File exists/mknod: \1: File exists/"
 }
 
 # make sure this script returns success