Message ID | 57BDD8560200007800108B7C@prv-mh.provo.novell.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Wed, Aug 24, 2016 at 09:24:38AM -0600, Jan Beulich wrote: > Program and section headers disagreed about the file offset at which > the build ID note lives. Gosh. That was an oversight. > > Reported-by: Sylvain Munaut <s.munaut@whatever-company.com> 'whatever-company'? Really? Huh. Imagine that. > Signed-off-by: Jan Beulich <jbeulich@suse.com> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > --- a/xen/arch/x86/boot/mkelf32.c > +++ b/xen/arch/x86/boot/mkelf32.c > @@ -394,7 +394,7 @@ int main(int argc, char **argv) > note_phdr.p_paddr = note_base; > note_phdr.p_filesz = note_sz; > note_phdr.p_memsz = note_sz; > - note_phdr.p_offset = offset; > + note_phdr.p_offset = RAW_OFFSET + offset; > > /* Tack on the .note\0 */ > out_shdr[2].sh_size += sizeof(out_shstrtab_extra); > > >
On 24/08/16 21:45, Konrad Rzeszutek Wilk wrote: > On Wed, Aug 24, 2016 at 09:24:38AM -0600, Jan Beulich wrote: >> Program and section headers disagreed about the file offset at which >> the build ID note lives. > Gosh. That was an oversight. >> Reported-by: Sylvain Munaut <s.munaut@whatever-company.com> > 'whatever-company'? Really? > > Huh. Imagine that. > >> Signed-off-by: Jan Beulich <jbeulich@suse.com> > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
--- a/xen/arch/x86/boot/mkelf32.c +++ b/xen/arch/x86/boot/mkelf32.c @@ -394,7 +394,7 @@ int main(int argc, char **argv) note_phdr.p_paddr = note_base; note_phdr.p_filesz = note_sz; note_phdr.p_memsz = note_sz; - note_phdr.p_offset = offset; + note_phdr.p_offset = RAW_OFFSET + offset; /* Tack on the .note\0 */ out_shdr[2].sh_size += sizeof(out_shstrtab_extra);