| Message ID | 1472278103-28320-1-git-send-email-baoyou.xie@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
On 27-8-2016 8:08, Baoyou Xie wrote: > We get 1 warning when biuld kernel with W=1: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: no previous prototype for '__brcmf_err' [-Wmissing- > prototypes] > > In fact, this function is declared in brcmfmac/debug.h, so this patch > add missing header dependencies Thanks for this fix, but please remove the 'fix:' prefix in the subject as it just noise. Regards, Arend > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c > index a10f35c..fe67559 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c > @@ -19,6 +19,7 @@ > #ifndef __CHECKER__ > #define CREATE_TRACE_POINTS > #include "tracepoint.h" > +#include "debug.h" > > void __brcmf_err(const char *func, const char *fmt, ...) > { >
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c index a10f35c..fe67559 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c @@ -19,6 +19,7 @@ #ifndef __CHECKER__ #define CREATE_TRACE_POINTS #include "tracepoint.h" +#include "debug.h" void __brcmf_err(const char *func, const char *fmt, ...) {
We get 1 warning when biuld kernel with W=1: drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: no previous prototype for '__brcmf_err' [-Wmissing- prototypes] In fact, this function is declared in brcmfmac/debug.h, so this patch add missing header dependencies Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c | 1 + 1 file changed, 1 insertion(+)