| Message ID | 20160901174702.8645-1-giedrius.statkevicius@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e34f2ff40e0339f6a379e1ecf49e8f2759056453 |
| Delegated to: | Kalle Valo |
| Headers | show |
Some more users complaining about this: https://bbs.archlinux.org/viewtopic.php?id=215978 On Thu, Sep 01, 2016 at 08:47:02PM +0300, Giedrius Statkevičius wrote: > A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup > led_pin initial") that broken the WLAN status led on my laptop with > AR9287 after suspending and resuming. > > Steps to reproduce: > * Suspend (laptop) > * Resume (laptop) > * Observe that the WLAN led no longer turns ON/OFF depending on the > status and is always red > > Even though for my case it only needs to be set to OUT in ath9k_start > but for consistency bring back the IN direction setting as well. > > Cc: Miaoqing Pan <miaoqing@codeaurora.org> > Cc: Kalle Valo <kvalo@qca.qualcomm.com> > Cc: <stable@vger.kernel.org> > Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com> > --- [...]
Giedrius Statkevi?ius <giedrius.statkevicius@gmail.com> wrote: > A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup > led_pin initial") that broken the WLAN status led on my laptop with > AR9287 after suspending and resuming. > > Steps to reproduce: > * Suspend (laptop) > * Resume (laptop) > * Observe that the WLAN led no longer turns ON/OFF depending on the > status and is always red > > Even though for my case it only needs to be set to OUT in ath9k_start > but for consistency bring back the IN direction setting as well. > > Cc: Miaoqing Pan <miaoqing@codeaurora.org> > Cc: Kalle Valo <kvalo@qca.qualcomm.com> > Cc: <stable@vger.kernel.org> > Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com> I'm planning to queue this to 4.8 if no objections.
Giedrius Statkevi?ius <giedrius.statkevicius@gmail.com> wrote: > A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup > led_pin initial") that broken the WLAN status led on my laptop with > AR9287 after suspending and resuming. > > Steps to reproduce: > * Suspend (laptop) > * Resume (laptop) > * Observe that the WLAN led no longer turns ON/OFF depending on the > status and is always red > > Even though for my case it only needs to be set to OUT in ath9k_start > but for consistency bring back the IN direction setting as well. > > Cc: Miaoqing Pan <miaoqing@codeaurora.org> > Cc: Kalle Valo <kvalo@qca.qualcomm.com> > Cc: <stable@vger.kernel.org> > Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com> Thanks, 1 patch applied to ath-next branch of ath.git: 088a60926b66 ath9k: bring back direction setting in ath9k_{start_stop}
Kalle Valo <kvalo@qca.qualcomm.com> writes: > Giedrius Statkevi?ius <giedrius.statkevicius@gmail.com> wrote: >> A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup >> led_pin initial") that broken the WLAN status led on my laptop with >> AR9287 after suspending and resuming. >> >> Steps to reproduce: >> * Suspend (laptop) >> * Resume (laptop) >> * Observe that the WLAN led no longer turns ON/OFF depending on the >> status and is always red >> >> Even though for my case it only needs to be set to OUT in ath9k_start >> but for consistency bring back the IN direction setting as well. >> >> Cc: Miaoqing Pan <miaoqing@codeaurora.org> >> Cc: Kalle Valo <kvalo@qca.qualcomm.com> >> Cc: <stable@vger.kernel.org> >> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com> > > Thanks, 1 patch applied to ath-next branch of ath.git: > > 088a60926b66 ath9k: bring back direction setting in ath9k_{start_stop} Oops, I was supposed to apply this to ath-current branch. Please ignore this. Luckily I didn't push yet so I can easily fix this.
Giedrius Statkevi?ius <giedrius.statkevicius@gmail.com> wrote: > A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup > led_pin initial") that broken the WLAN status led on my laptop with > AR9287 after suspending and resuming. > > Steps to reproduce: > * Suspend (laptop) > * Resume (laptop) > * Observe that the WLAN led no longer turns ON/OFF depending on the > status and is always red > > Even though for my case it only needs to be set to OUT in ath9k_start > but for consistency bring back the IN direction setting as well. > > Cc: Miaoqing Pan <miaoqing@codeaurora.org> > Cc: Kalle Valo <kvalo@qca.qualcomm.com> > Cc: <stable@vger.kernel.org> > Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com> Thanks, 1 patch applied to ath-current branch of ath.git: e34f2ff40e03 ath9k: bring back direction setting in ath9k_{start_stop}
diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c index 8b63988..121dc05 100644 --- a/drivers/net/wireless/ath/ath9k/main.c +++ b/drivers/net/wireless/ath/ath9k/main.c @@ -718,9 +718,12 @@ static int ath9k_start(struct ieee80211_hw *hw) if (!ath_complete_reset(sc, false)) ah->reset_power_on = false; - if (ah->led_pin >= 0) + if (ah->led_pin >= 0) { ath9k_hw_set_gpio(ah, ah->led_pin, (ah->config.led_active_high) ? 1 : 0); + ath9k_hw_gpio_request_out(ah, ah->led_pin, NULL, + AR_GPIO_OUTPUT_MUX_AS_OUTPUT); + } /* * Reset key cache to sane defaults (all entries cleared) instead of @@ -864,9 +867,11 @@ static void ath9k_stop(struct ieee80211_hw *hw) spin_lock_bh(&sc->sc_pcu_lock); - if (ah->led_pin >= 0) + if (ah->led_pin >= 0) { ath9k_hw_set_gpio(ah, ah->led_pin, (ah->config.led_active_high) ? 0 : 1); + ath9k_hw_gpio_request_in(ah, ah->led_pin, NULL); + } ath_prepare_reset(sc);
A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup led_pin initial") that broken the WLAN status led on my laptop with AR9287 after suspending and resuming. Steps to reproduce: * Suspend (laptop) * Resume (laptop) * Observe that the WLAN led no longer turns ON/OFF depending on the status and is always red Even though for my case it only needs to be set to OUT in ath9k_start but for consistency bring back the IN direction setting as well. Cc: Miaoqing Pan <miaoqing@codeaurora.org> Cc: Kalle Valo <kvalo@qca.qualcomm.com> Cc: <stable@vger.kernel.org> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com> --- This patch should be applied to all 4.7 and later kernels Another user complaining about probably the same problem: https://bugzilla.kernel.org/show_bug.cgi?id=151711 drivers/net/wireless/ath/ath9k/main.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)