[libibverbs,v2,1/3] Add new call ibv_cmd_create_ah_ex which supports extra parameters

Commit Message

Knut Omang Sept. 19, 2016, 4:36 a.m. UTC

On Mon, 2016-09-19 at 06:29 +0200, Knut Omang wrote:
> On Sun, 2016-09-18 at 22:08 -0600, Jason Gunthorpe wrote:
> > On Mon, Sep 19, 2016 at 05:51:03AM +0200, Knut Omang wrote:
> > 
> > > I was a bit concerned about the "structure", but ultimately decided to
> > > follow the pattern since I could not find any documentation with this syntax
> > > (which is probably because it is not supported?)
> > 
> > It is something carried over from Solaris, it is not implemented in
> > linux today, but it is good practice to follow the solaris
> > method. Drepper talks about it in his various documentations of symbol
> > versioning.
> > 
> > Each stanza should refer to its predecessor.
> 
> Ok, I see...
> That also means that this patch would have to be based on the IBVERBS_1.2 and IBVERBS_1.3 fixups
> to avoid introducing conflicts.

I tested this, which seems to work fine, but I am not sure you want it ;-) :

+} IBVERBS_1.3;


Knut
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Jason Gunthorpe Sept. 19, 2016, 4:59 p.m. UTC | #1

On Mon, Sep 19, 2016 at 06:36:32AM +0200, Knut Omang wrote:
> diff --git a/src/libibverbs.map b/src/libibverbs.map
> index 5134bd9..979980d 100644
> +++ b/src/libibverbs.map
> @@ -118,5 +118,15 @@ IBVERBS_1.1 {
>                 ibv_cmd_create_qp_ex2;
>                 ibv_cmd_open_qp;
>                 ibv_cmd_rereg_mr;
>  } IBVERBS_1.0;
> 
> +IBVERBS_1.2 {
> +} IBVERBS_1.1;

This is the right idea, but we won't be going back to fix the bad tags
from 1.2 and other releases so this can be dropped.

> +IBVERBS_1.3 {
> +} IBVERBS_1.2;

If you pull from Doug's tree right now you'll get a populated version
of this stanza

> +IBVERBS_1.4 {
> + global:
> +         ibv_cmd_create_ah_ex;
> +} IBVERBS_1.3;

Right. Doug will have to figure out a process for these, eg if he
hasn't released 1.3 yet then this can be folded into 1.3.

It is critical that once a release is made that the existing stanza's
not be changed.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Knut Omang Sept. 20, 2016, 4:42 a.m. UTC | #2

On Mon, 2016-09-19 at 10:59 -0600, Jason Gunthorpe wrote:
> On Mon, Sep 19, 2016 at 06:36:32AM +0200, Knut Omang wrote:
> > diff --git a/src/libibverbs.map b/src/libibverbs.map
> > index 5134bd9..979980d 100644
> > +++ b/src/libibverbs.map
> > @@ -118,5 +118,15 @@ IBVERBS_1.1 {
> >                 ibv_cmd_create_qp_ex2;
> >                 ibv_cmd_open_qp;
> >                 ibv_cmd_rereg_mr;
> >  } IBVERBS_1.0;
> > 
> > +IBVERBS_1.2 {
> > +} IBVERBS_1.1;
> 
> This is the right idea, but we won't be going back to fix the bad tags
> from 1.2 and other releases so this can be dropped.
> 
> > +IBVERBS_1.3 {
> > +} IBVERBS_1.2;
> 
> If you pull from Doug's tree right now you'll get a populated version
> of this stanza
> 
> > +IBVERBS_1.4 {
> > + global:
> > +         ibv_cmd_create_ah_ex;
> > +} IBVERBS_1.3;
> 
> Right. Doug will have to figure out a process for these, eg if he
> hasn't released 1.3 yet then this can be folded into 1.3.
> 
> It is critical that once a release is made that the existing stanza's
> not be changed.

Ok, fine - I see no 1.3.x tag yet so will post av v3 with this fix now.

Thanks,
Knut
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/src/libibverbs.map b/src/libibverbs.map
index 5134bd9..979980d 100644
--- a/src/libibverbs.map
+++ b/src/libibverbs.map
@@ -118,5 +118,15 @@  IBVERBS_1.1 {
                ibv_cmd_create_qp_ex2;
                ibv_cmd_open_qp;
                ibv_cmd_rereg_mr;
 } IBVERBS_1.0;

+IBVERBS_1.2 {
+} IBVERBS_1.1;
+
+
+IBVERBS_1.3 {
+} IBVERBS_1.2;
+
+IBVERBS_1.4 {
+ global:
+         ibv_cmd_create_ah_ex;