Message ID | 147629570687.26062.4786752681864367162.stgit@localhost.localdomain (mailing list archive) |
---|---|
State | Accepted |
Commit | 1ea2643961b0d1b8d0e4a11af5aa69b0f92d0533 |
Delegated to: | Kalle Valo |
Headers | show |
Hi Alan, Sorry to quibble, but the subsystem label on the commit subject line should be "ath6kl:" it's a lower-case "L", not a one. On Wed, Oct 12, 2016 at 11:08 AM, Alan <alan@linux.intel.com> wrote: > From: Adam Williamson <adamw@happyassassin.net> > > SDIO ID 0271:0418 > > Signed-off-by: Alan Cox <alan@linux.intel.com> > Bugzilla-ID: https://bugzilla.kernel.org/show_bug.cgi?id=67921 > > diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c b/drivers/net/wireless/ath/ath6kl/sdio.c > index eab0ab9..76eb336 100644 > --- a/drivers/net/wireless/ath/ath6kl/sdio.c > +++ b/drivers/net/wireless/ath/ath6kl/sdio.c > @@ -1401,6 +1401,7 @@ static const struct sdio_device_id ath6kl_sdio_devices[] = { > {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x0))}, > {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x1))}, > {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x2))}, > + {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x18))}, > {}, > }; > > I see nothing wrong with this if the chip does indeed identify itself this way. So please fix the subject and you can add: Reviewed-by: Steve deRosier <steve.derosier@lairdtech.com> - Steve
Steve deRosier <derosier@gmail.com> writes: > Sorry to quibble, but the subsystem label on the commit subject line > should be "ath6kl:" it's a lower-case "L", not a one. Heh, I missed that :) I can fix it before I commit. >> --- a/drivers/net/wireless/ath/ath6kl/sdio.c >> +++ b/drivers/net/wireless/ath/ath6kl/sdio.c >> @@ -1401,6 +1401,7 @@ static const struct sdio_device_id ath6kl_sdio_devices[] = { >> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x0))}, >> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x1))}, >> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x2))}, >> + {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x18))}, >> {}, >> }; >> >> > > I see nothing wrong with this if the chip does indeed identify itself > this way. So please fix the subject and you can add: > > Reviewed-by: Steve deRosier <steve.derosier@lairdtech.com> Thanks.
Alan Cox <alan@linux.intel.com> wrote: > From: Adam Williamson <adamw@happyassassin.net> > > SDIO ID 0271:0418 > > Signed-off-by: Alan Cox <alan@linux.intel.com> > Bugzilla-ID: https://bugzilla.kernel.org/show_bug.cgi?id=67921 > Reviewed-by: Steve deRosier <steve.derosier@lairdtech.com> > > diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c b/drivers/net/wireless/ath/ath6kl/sdio.c > index eab0ab9..76eb336 100644 > --- a/drivers/net/wireless/ath/ath6kl/sdio.c > +++ b/drivers/net/wireless/ath/ath6kl/sdio.c > @@ -1401,6 +1401,7 @@ static const struct sdio_device_id ath6kl_sdio_devices[] = { > {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x0))}, > {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x1))}, > {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x2))}, > + {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x18))}, > {}, > }; > Patch applied to ath-current branch of ath.git, thanks. 1ea2643961b0 ath6kl: add Dell OEM SDIO I/O for the Venue 8 Pro
diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c b/drivers/net/wireless/ath/ath6kl/sdio.c index eab0ab9..76eb336 100644 --- a/drivers/net/wireless/ath/ath6kl/sdio.c +++ b/drivers/net/wireless/ath/ath6kl/sdio.c @@ -1401,6 +1401,7 @@ static const struct sdio_device_id ath6kl_sdio_devices[] = { {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x0))}, {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x1))}, {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x2))}, + {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x18))}, {}, };